Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency

From	Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency
Date	2017-07-25 14:00 +0200
Message-ID	<u76Fk-2je-9@gated-at.bofh.it> (permalink)
References	<u5NbI-18q-25@gated-at.bofh.it> <u6GBc-2ba-3@gated-at.bofh.it> <u72BI-8li-19@gated-at.bofh.it> <u734L-iG-39@gated-at.bofh.it> <u76lY-2cr-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2017-07-25 at 13:35 +0200, Arnd Bergmann wrote:
> On Tue, Jul 25, 2017 at 10:03 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> > On Tue, 2017-07-25 at 09:33 +0200, Arnd Bergmann wrote:
> >> On Mon, Jul 24, 2017 at 10:05 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> >> > On Fri, 2017-07-21 at 22:56 +0200, Arnd Bergmann wrote:
> 
> >> If you only need build-testing, you could have a simple wrapper like
> >>
> >> const struct drm_format_info *ipu_format_info(u32 format)
> >> {
> >>          static const struct drm_format_info invalid = {};
> >>
> >>          if (!IS_REACHABLE(CONFIG_DRM))
> >>                   return &invalid;
> >>
> >>          return drm_format_info(format);
> >> }
> >
> > That should work fine. Both ipu_prg_format_supported and
> > ipu_prg_channel_configure are only ever called by DRM code.
> 
> Ok, in that case, I think we should just make the compilation
> of PRE and PRG conditional and leave them out when DRM
> is not built-in (be aware of the case of DRM=m, IPU=y).

Maybe we should just:

config IMX_IPUV3_CORE
	depends on DRM || !DRM # if DRM=m, this can't be 'y'

regards
Philipp

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-21 23:00 +0200
  Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Philipp Zabel <p.zabel@pengutronix.de> - 2017-07-24 10:10 +0200
    Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-25 09:40 +0200
      Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Philipp Zabel <p.zabel@pengutronix.de> - 2017-07-25 10:10 +0200
        Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-25 13:40 +0200
          Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-25 14:00 +0200
          Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Philipp Zabel <p.zabel@pengutronix.de> - 2017-07-25 14:00 +0200

csiph-web