Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency
Date	2017-07-25 14:00 +0200
Message-ID	<u76Fk-2je-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <u6GBc-2ba-3@gated-at.bofh.it> <u72BI-8li-19@gated-at.bofh.it> <u734L-iG-39@gated-at.bofh.it> <u76lY-2cr-17@gated-at.bofh.it> <u76Fk-2je-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 25, 2017 at 1:52 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> On Tue, 2017-07-25 at 13:35 +0200, Arnd Bergmann wrote:
>> On Tue, Jul 25, 2017 at 10:03 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>> > On Tue, 2017-07-25 at 09:33 +0200, Arnd Bergmann wrote:
>> >> On Mon, Jul 24, 2017 at 10:05 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>> >> > On Fri, 2017-07-21 at 22:56 +0200, Arnd Bergmann wrote:
>>
>> >> If you only need build-testing, you could have a simple wrapper like
>> >>
>> >> const struct drm_format_info *ipu_format_info(u32 format)
>> >> {
>> >>          static const struct drm_format_info invalid = {};
>> >>
>> >>          if (!IS_REACHABLE(CONFIG_DRM))
>> >>                   return &invalid;
>> >>
>> >>          return drm_format_info(format);
>> >> }
>> >
>> > That should work fine. Both ipu_prg_format_supported and
>> > ipu_prg_channel_configure are only ever called by DRM code.
>>
>> Ok, in that case, I think we should just make the compilation
>> of PRE and PRG conditional and leave them out when DRM
>> is not built-in (be aware of the case of DRM=m, IPU=y).
>
> Maybe we should just:
>
> config IMX_IPUV3_CORE
>         depends on DRM || !DRM # if DRM=m, this can't be 'y'

Yes, that would solve that case. I see now that the DRM=n
case is already handled by 30310c835f3e ("gpu: ipu-v3: don't
depend on DRM being enabled"), so that is probably sufficient.

I've added that change to my randconfig tree now and will give
it some more testing. If you don't hear back from me, please assume
that it works, and send that version upstream.

      Arnd

Thread

[PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-21 23:00 +0200
  Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Philipp Zabel <p.zabel@pengutronix.de> - 2017-07-24 10:10 +0200
    Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-25 09:40 +0200
      Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Philipp Zabel <p.zabel@pengutronix.de> - 2017-07-25 10:10 +0200
        Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-25 13:40 +0200
          Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-25 14:00 +0200
          Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency Philipp Zabel <p.zabel@pengutronix.de> - 2017-07-25 14:00 +0200

csiph-web