Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1695538

Re: [PATCH v5 08/19] coresight tmc: Add helpers for accessing 64bit registers

Show all headers | View raw

On 24/07/17 18:11, Mathieu Poirier wrote:
> On 20 July 2017 at 04:17, Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>> Coresight TMC splits 64bit registers into a pair of 32bit registers
>> (e.g DBA, RRP, RWP). Provide helpers to read/write to these registers.
>>
>> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>> diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h
>> index 51c0185..c78de00 100644
>> --- a/drivers/hwtracing/coresight/coresight-tmc.h
>> +++ b/drivers/hwtracing/coresight/coresight-tmc.h
>> @@ -18,6 +18,7 @@
>>  #ifndef _CORESIGHT_TMC_H
>>  #define _CORESIGHT_TMC_H
>>
>> +#include <linux/io.h>
>
> Is this needed?  I recompiled on my side without it and nothing breaks.
>

I think it is a left over from rebase, where I initially open coded the
read/write_relaxed here and then later moved to the coresight-priv.h. So,
yes, please could you fix it up when you commit ?

Cheers
Suzuki

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 00/19] coresight: Support for ARM Coresight SoC-600 Suzuki K Poulose <suzuki.poulose@arm.com> - 2017-07-20 12:20 +0200
  [PATCH v5 13/19] coresight tmc: Detect support for scatter gather Suzuki K Poulose <suzuki.poulose@arm.com> - 2017-07-20 12:20 +0200
  [PATCH v5 18/19] coresight tmc: Add support for Coresight SoC 600 TMC Suzuki K Poulose <suzuki.poulose@arm.com> - 2017-07-20 12:20 +0200
    Re: [PATCH v5 18/19] coresight tmc: Add support for Coresight SoC 600 TMC Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-07-24 19:20 +0200
      Re: [PATCH v5 18/19] coresight tmc: Add support for Coresight SoC 600  TMC Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2017-07-25 11:40 +0200
  [PATCH v5 08/19] coresight tmc: Add helpers for accessing 64bit registers Suzuki K Poulose <suzuki.poulose@arm.com> - 2017-07-20 12:20 +0200
    Re: [PATCH v5 08/19] coresight tmc: Add helpers for accessing 64bit registers Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-07-24 19:20 +0200
      Re: [PATCH v5 08/19] coresight tmc: Add helpers for accessing 64bit  registers Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2017-07-25 11:30 +0200
  [PATCH v5 07/19] coresight: Use the new helper for defining registers Suzuki K Poulose <suzuki.poulose@arm.com> - 2017-07-20 12:30 +0200
  [PATCH v5 06/19] coresight: Add support for reading 64bit registers Suzuki K Poulose <suzuki.poulose@arm.com> - 2017-07-20 12:30 +0200
  [PATCH v5 05/19] coresight: Extend the PIDR mask to cover relevant bits in PIDR2 Suzuki K Poulose <suzuki.poulose@arm.com> - 2017-07-20 12:30 +0200
  [PATCH v5 10/19] coresight replicator: Expose replicator management registers Suzuki K Poulose <suzuki.poulose@arm.com> - 2017-07-20 12:30 +0200
  [PATCH v5 04/19] arm64: qcom-msm8916: dts: Update coresight replicator Suzuki K Poulose <suzuki.poulose@arm.com> - 2017-07-20 12:30 +0200
  [PATCH v5 03/19] arm: qcom-msm8974: dts: Update coresight replicator Suzuki K Poulose <suzuki.poulose@arm.com> - 2017-07-20 12:30 +0200
    Re: [PATCH v5 03/19] arm: qcom-msm8974: dts: Update coresight  replicator Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2017-07-27 13:20 +0200
      Re: [PATCH v5 03/19] arm: qcom-msm8974: dts: Update coresight  replicator Andy Gross <andy.gross@linaro.org> - 2017-07-27 23:10 +0200
  [PATCH v5 09/19] coresight tmc: Expose DBA and AXICTL Suzuki K Poulose <suzuki.poulose@arm.com> - 2017-07-20 12:30 +0200
  [PATCH v5 02/19] arm64: juno: dts: Use the new coresight replicator string Suzuki K Poulose <suzuki.poulose@arm.com> - 2017-07-20 12:30 +0200
    Re: [PATCH v5 02/19] arm64: juno: dts: Use the new coresight  replicator string Liviu Dudau <liviu.dudau@arm.com> - 2017-07-20 15:00 +0200
      Re: [PATCH v5 02/19] arm64: juno: dts: Use the new coresight  replicator string Sudeep Holla <sudeep.holla@arm.com> - 2017-07-27 13:30 +0200
  [PATCH v5 01/19] coresight replicator: Cleanup programmable replicator naming Suzuki K Poulose <suzuki.poulose@arm.com> - 2017-07-20 12:30 +0200
  Re: [PATCH v5 00/19] coresight: Support for ARM Coresight SoC-600 Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-07-24 19:20 +0200
    Re: [PATCH v5 00/19] coresight: Support for ARM Coresight SoC-600 Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2017-07-25 11:50 +0200

csiph-web