Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1695561

Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in icm_suspend()

Show all headers | View raw

On Tue, Jul 25, 2017 at 01:31:00AM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> On one of my test machines nhi_mailbox_cmd() called from icm_suspend()
> times out and returnes an error which then is propagated to the
> caller and causes the entire system suspend to be aborted which isn't
> very useful.
> 
> Instead of aborting system suspend, print the error into the log
> and continue.

I agree, it should not prevent suspend but I wonder why it fails in the
first place? Can you check what is the return value?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in icm_suspend() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-25 01:40 +0200
  Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in  icm_suspend() Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-07-25 12:10 +0200
    Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in icm_suspend() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-25 18:20 +0200
      Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in  icm_suspend() Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-07-26 10:40 +0200
        Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in icm_suspend() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-26 15:00 +0200
          Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in  icm_suspend() Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-07-26 15:20 +0200
            Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in icm_suspend() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-26 19:20 +0200
              Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in  icm_suspend() Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-07-27 11:00 +0200
                Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in icm_suspend() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-28 02:10 +0200
              RE: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in  icm_suspend() "Jamet, Michael" <michael.jamet@intel.com> - 2017-07-31 09:10 +0200
                Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in icm_suspend() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-31 11:40 +0200

csiph-web