Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1695376

Re: [PATCH] powerpc/pseries: Fix of_node_put() underflow during pseries remove

Show all headers | View raw

Tyrel Datwyler <turtle.in.the.kernel@gmail.com> writes:

> On 07/24/2017 03:42 AM, Michael Ellerman wrote:
>> Laurent Vivier <lvivier@redhat.com> writes:
>> 
>>> As for commit 68baf692c435 ("powerpc/pseries: Fix of_node_put()
>>> underflow during DLPAR remove"), the call to of_node_put()
>>> must be removed from pSeries_reconfig_remove_node().
>>>
>>> dlpar_detach_node() and pSeries_reconfig_remove_node() call
>>> of_detach_node(), and thus the node should not be released
>>> in this case too.
>>>
>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>>> ---
>>>  arch/powerpc/platforms/pseries/reconfig.c | 1 -
>>>  1 file changed, 1 deletion(-)
>> 
>> Thanks. I'll spare you the swearing about why we have the same bug in
>> two places.
>
> That's probably my bad. I must have failed to test with older powerpc-util tooling where
> drmgr uses the /proc/ofdt interface for device tree modification.

OK. Really we should have automated tests of the various cases, I've
just never had time to write any.

Mainly the thing that bugs me is that we still have the two separate
paths. Or if we must maintain both they could at least share more code,
the two functions do basically the same thing AFAICS.

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] powerpc/pseries: Fix of_node_put() underflow during pseries remove Laurent Vivier <lvivier@redhat.com> - 2017-07-21 17:00 +0200
  Re: [PATCH] powerpc/pseries: Fix of_node_put() underflow during  pseries remove David Gibson <david@gibson.dropbear.id.au> - 2017-07-24 03:10 +0200
  Re: [PATCH] powerpc/pseries: Fix of_node_put() underflow during pseries remove Michael Ellerman <mpe@ellerman.id.au> - 2017-07-24 12:50 +0200
    Re: [PATCH] powerpc/pseries: Fix of_node_put() underflow during  pseries remove Tyrel Datwyler <turtle.in.the.kernel@gmail.com> - 2017-07-24 20:50 +0200
      Re: [PATCH] powerpc/pseries: Fix of_node_put() underflow during pseries remove Michael Ellerman <mpe@ellerman.id.au> - 2017-07-25 06:50 +0200
        Re: [PATCH] powerpc/pseries: Fix of_node_put() underflow during  pseries remove Tyrel Datwyler <turtle.in.the.kernel@gmail.com> - 2017-07-25 20:00 +0200
  Re: powerpc/pseries: Fix of_node_put() underflow during pseries remove Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-07-27 14:40 +0200

csiph-web