[PATCH] powerpc/pseries: Fix of_node_put() underflow during pseries remove

From	Laurent Vivier <lvivier@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH] powerpc/pseries: Fix of_node_put() underflow during pseries remove
Date	2017-07-21 17:00 +0200
Message-ID	<u5Hzk-663-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

As for commit 68baf692c435 ("powerpc/pseries: Fix of_node_put()
underflow during DLPAR remove"), the call to of_node_put()
must be removed from pSeries_reconfig_remove_node().

dlpar_detach_node() and pSeries_reconfig_remove_node() call
of_detach_node(), and thus the node should not be released
in this case too.

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 arch/powerpc/platforms/pseries/reconfig.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/reconfig.c b/arch/powerpc/platforms/pseries/reconfig.c
index e5bf1e8..011ef21 100644
--- a/arch/powerpc/platforms/pseries/reconfig.c
+++ b/arch/powerpc/platforms/pseries/reconfig.c
@@ -82,7 +82,6 @@ static int pSeries_reconfig_remove_node(struct device_node *np)
 
 	of_detach_node(np);
 	of_node_put(parent);
-	of_node_put(np); /* Must decrement the refcount */
 	return 0;
 }
 
-- 
2.9.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] powerpc/pseries: Fix of_node_put() underflow during pseries remove Laurent Vivier <lvivier@redhat.com> - 2017-07-21 17:00 +0200
  Re: [PATCH] powerpc/pseries: Fix of_node_put() underflow during  pseries remove David Gibson <david@gibson.dropbear.id.au> - 2017-07-24 03:10 +0200
  Re: [PATCH] powerpc/pseries: Fix of_node_put() underflow during pseries remove Michael Ellerman <mpe@ellerman.id.au> - 2017-07-24 12:50 +0200
    Re: [PATCH] powerpc/pseries: Fix of_node_put() underflow during  pseries remove Tyrel Datwyler <turtle.in.the.kernel@gmail.com> - 2017-07-24 20:50 +0200
      Re: [PATCH] powerpc/pseries: Fix of_node_put() underflow during pseries remove Michael Ellerman <mpe@ellerman.id.au> - 2017-07-25 06:50 +0200
        Re: [PATCH] powerpc/pseries: Fix of_node_put() underflow during  pseries remove Tyrel Datwyler <turtle.in.the.kernel@gmail.com> - 2017-07-25 20:00 +0200
  Re: powerpc/pseries: Fix of_node_put() underflow during pseries remove Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-07-27 14:40 +0200

csiph-web