Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1693313

Re: cpuidle and cpufreq coupling?

Show all headers | View raw

On 07/20/2017 05:11 PM, Vikram Mulukutla wrote:
> On 7/20/2017 3:56 PM, Florian Fainelli wrote:
>> On 07/20/2017 07:45 AM, Peter Zijlstra wrote:
> 
> <snip>
> 
>>>
>>> Can your ARM part change OPP without scheduling? Because (for obvious
>>> reasons) the idle thread is not supposed to block.
>>
>> I think it should be able to do that, but I am not sure that if I went
>> through the cpufreq API it would be that straight forward so I may have
>> to re-implement some of the frequency scaling logic outside of cpufreq
>> (or rather make the low-level parts some kind of library I guess).
>>
> 
> I think I can safely mention that some of our non-upstream idle drivers
> in the past have invoked low level clock drivers to atomically switch
> CPUs to low frequency OPPs, with no interaction whatsoever with cpufreq.
> It was maintainable since both the idle and clock drivers were
> qcom-specific. However this is no longer necessary in recent designs and
> I really hope we never need to do this again...

Yes same here, this is for a past generation product, current generation
has a smarter design that so far does not require that.

> 
> We didn't have to do a voltage switch and just PLL or mux
> work so this was doable. I'm guessing your atomic switching also allows
> voltage reduction?

Correct there is a voltage reduction occurring which is largely under
control of a separate MCU/firmware.

> 
> If your architecture allows another CPU to change the entering-idle CPU's
> frequency, synchronization will be necessary as well - this is where it
> can get a bit tricky.

That is a very good point, the frequency scaling is not per-CPU but for
the entire CPU complex (up to 4 cores) so that might indeed be a problem.

Thanks!
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

cpuidle and cpufreq coupling? Florian Fainelli <f.fainelli@gmail.com> - 2017-07-20 01:00 +0200
  Re: cpuidle and cpufreq coupling? "Rafael J. Wysocki" <rafael@kernel.org> - 2017-07-20 01:20 +0200
    Re: cpuidle and cpufreq coupling? Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-20 09:20 +0200
      Re: cpuidle and cpufreq coupling? Sudeep Holla <sudeep.holla@arm.com> - 2017-07-20 11:30 +0200
        Re: cpuidle and cpufreq coupling? Florian Fainelli <f.fainelli@gmail.com> - 2017-07-21 01:10 +0200
      Re: cpuidle and cpufreq coupling? "Rafael J. Wysocki" <rafael@kernel.org> - 2017-07-20 12:00 +0200
        Re: cpuidle and cpufreq coupling? Peter Zijlstra <peterz@infradead.org> - 2017-07-20 16:50 +0200
          Re: cpuidle and cpufreq coupling? Florian Fainelli <f.fainelli@gmail.com> - 2017-07-21 01:00 +0200
            Re: cpuidle and cpufreq coupling? Vikram Mulukutla <markivx@codeaurora.org> - 2017-07-21 02:20 +0200
              Re: cpuidle and cpufreq coupling? Florian Fainelli <f.fainelli@gmail.com> - 2017-07-21 02:40 +0200

csiph-web