Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1693261

Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

Show all headers | View raw

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Thu, 20 Jul 2017 11:08:09 -0500

> In general patch looks good to me, but it's really unexpected to
> receive IRQs while CPSW is probing ;(

This is a poor expectation.

Boot loaders and other entities can leave the device in any state
whatsoever.

Furthermore, enabling an IRQ whose handler cannot properly execute
without crashing is wrong fundamentally.  All data structures and
state must be set up properly before the IRQ is requested.

Therefore this patch is correct and I will apply it.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe Keerthy <j-keerthy@ti.com> - 2017-07-20 13:40 +0200
  Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to  the end of probe Grygorii Strashko <grygorii.strashko@ti.com> - 2017-07-20 18:10 +0200
    Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function  to the end of probe David Miller <davem@davemloft.net> - 2017-07-21 00:30 +0200
      Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to  the end of probe Grygorii Strashko <grygorii.strashko@ti.com> - 2017-07-21 00:50 +0200
        Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to  the end of probe Keerthy <j-keerthy@ti.com> - 2017-07-21 06:50 +0200
          Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to  the end of probe Grygorii Strashko <grygorii.strashko@ti.com> - 2017-07-21 18:00 +0200

csiph-web