Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

From	Grygorii Strashko <grygorii.strashko@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe
Date	2017-07-21 18:00 +0200
Message-ID	<u5Ivp-6HH-29@gated-at.bofh.it> (permalink)
References	<u5hYf-6H9-9@gated-at.bofh.it> <u5mbw-1jG-27@gated-at.bofh.it> <u5s7h-4UV-13@gated-at.bofh.it> <u5sqB-54d-1@gated-at.bofh.it> <u5y2Z-aa-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 07/20/2017 11:45 PM, Keerthy wrote:
> 
> 
> On Friday 21 July 2017 04:14 AM, Grygorii Strashko wrote:
>>
>>
>> On 07/20/2017 05:28 PM, David Miller wrote:
>>> From: Grygorii Strashko <grygorii.strashko@ti.com>
>>> Date: Thu, 20 Jul 2017 11:08:09 -0500
>>>
>>>> In general patch looks good to me, but it's really unexpected to
>>>> receive IRQs while CPSW is probing ;(
>>>
>>> This is a poor expectation.
>>>
>>> Boot loaders and other entities can leave the device in any state
>>> whatsoever.
>>>
>>> Furthermore, enabling an IRQ whose handler cannot properly execute
>>> without crashing is wrong fundamentally.  All data structures and
>>> state must be set up properly before the IRQ is requested.
>>>
>>> Therefore this patch is correct and I will apply it.
>>>
>>
>> Thanks. Agree (it just has never triggered before, so I meant - unexpected
>>   from current driver code point of view ;().
>> And I'm just worry that it might not be enough :(, especially for am335x.
> 
> I tried nfs boot on am335x-evm with this patch and it boots fine for me.
> 

Thank you Keerthy, I've also simulated and tested it on am335x and dra7
and see networking working and no crashes.

-- 
regards,
-grygorii

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe Keerthy <j-keerthy@ti.com> - 2017-07-20 13:40 +0200
  Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to  the end of probe Grygorii Strashko <grygorii.strashko@ti.com> - 2017-07-20 18:10 +0200
    Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function  to the end of probe David Miller <davem@davemloft.net> - 2017-07-21 00:30 +0200
      Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to  the end of probe Grygorii Strashko <grygorii.strashko@ti.com> - 2017-07-21 00:50 +0200
        Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to  the end of probe Keerthy <j-keerthy@ti.com> - 2017-07-21 06:50 +0200
          Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to  the end of probe Grygorii Strashko <grygorii.strashko@ti.com> - 2017-07-21 18:00 +0200

csiph-web