Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1693148

Re: [PATCH v2 2/3] PM / sleep: Mark suspend/hibernation start and finish

Show all headers | View raw

On 07/19/2017 06:38 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Regardless of whether or not debug messages from the core system
> suspend/hibernation code are enabled, it is useful to know when
> system-wide transitions start and finish (or fail), so print "info"
> messages at these points.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>
> -> v2: Smiplified the messages as suggested by Mark.
>
> ---
>   kernel/power/hibernate.c |    5 +++++
>   kernel/power/suspend.c   |    2 ++
>   2 files changed, 7 insertions(+)
>
> Index: linux-pm/kernel/power/hibernate.c
> ===================================================================
> --- linux-pm.orig/kernel/power/hibernate.c
> +++ linux-pm/kernel/power/hibernate.c
> @@ -692,6 +692,7 @@ int hibernate(void)
>   		goto Unlock;
>   	}
>   
> +	pr_info("hibernation entry\n");
nit (minor): Many of the logs report a PM: prefix. Flipping coin that 
the 3 characters provides any real gain is in your hands. My WAG is it 
would be nice to be able to do dmesg | grep PM:

Ack

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] PM / sleep: Avoid filling up kernel log buffer with debug messages "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-19 03:00 +0200
  [PATCH 3/3] PM / timekeeping: Print debug messages when requested "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-19 03:00 +0200
    Re: [PATCH 3/3] PM / timekeeping: Print debug messages when requested "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-21 00:10 +0200
  [PATCH 2/3] PM / sleep: Mark suspend/hibernation start and finish "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-19 03:00 +0200
    [PATCH v2 2/3] PM / sleep: Mark suspend/hibernation start and finish "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-20 03:50 +0200
      Re: [PATCH v2 2/3] PM / sleep: Mark suspend/hibernation start and  finish Mark Salyzyn <salyzyn@android.com> - 2017-07-20 20:00 +0200
        Re: [PATCH v2 2/3] PM / sleep: Mark suspend/hibernation start and finish "Rafael J. Wysocki" <rafael@kernel.org> - 2017-07-20 23:10 +0200

csiph-web