Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1693149

Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot

Show all headers | View raw

Borislav Petkov <bp@suse.de> writes:

> On Thu, Jul 20, 2017 at 01:29:17PM +0100, Punit Agrawal wrote:
>> I agree that where there is a genuine problem, relevant messages can
>> help to diagnose the problem. But what's printed now doesn't fit the
>> criteria.
>
> So make it fit the criteria. Change the code to not issue that message
> when the platform doesn't have those tables. But keep it in the
> remaining cases, when the tables are there.
>
> You can't be removing useful error messages just because your platform
> doesn't have the tables.

Fair point! I'll focus on quiescing the messages when the tables are not
present.

Inspired by your suggestion, I tried the following diff instead of
$SUBJECT.

diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
index 456b488eb1df..f7784d9514e1 100644
--- a/drivers/acpi/apei/hest.c
+++ b/drivers/acpi/apei/hest.c
@@ -233,8 +233,9 @@ void __init acpi_hest_init(void)
        status = acpi_get_table(ACPI_SIG_HEST, 0,
                                (struct acpi_table_header **)&hest_tab);
        if (status == AE_NOT_FOUND)
-           goto err;
-   else if (ACPI_FAILURE(status)) {
+         return;
+
+ if (ACPI_FAILURE(status)) {
                const char *msg = acpi_format_exception(status);
                pr_err(HEST_PFX "Failed to get table, %s\n", msg);
                rc = -EINVAL;

This landed me a new message not seen before -

[    3.232940] GHES: Failed to enable APEI firmware first mode.

On further digging, this message is printed on platforms not supporting
the legacy WHEA stuff, when the APEI Support bit is not set in the
platform wide _OSC capabilities.

To make this message a bit less alarming, I can modify it to something
like -

"Firmware does not support APEI firmware first mode"

Thoughts?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-07-20 13:10 +0200
  Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot Borislav Petkov <bp@suse.de> - 2017-07-20 13:20 +0200
    Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-07-20 14:30 +0200
      Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot Borislav Petkov <bp@suse.de> - 2017-07-20 16:00 +0200
        Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-07-20 20:00 +0200
          Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot Borislav Petkov <bp@suse.de> - 2017-07-21 15:30 +0200
            Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-07-27 11:40 +0200
              Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot Borislav Petkov <bp@suse.de> - 2017-07-27 12:00 +0200
                Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-07-27 12:00 +0200

csiph-web