Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1694019

Re: [PATCH] staging: vboxvideo: make a couple of symbols static

Show all headers | View raw

Hi,

On 19-07-17 11:36, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Module parameter vbox_modeset and structure vbox_bo_driver do not need to
> be in global scope and hence can be made static.
> 
> Cleans up a couple of sparse warnings:
> symbol 'vbox_modeset' was not declared. Should it be static?
> symbol 'vbox_bo_driver' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Looks good to me:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>   drivers/staging/vboxvideo/vbox_drv.c | 2 +-
>   drivers/staging/vboxvideo/vbox_ttm.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vboxvideo/vbox_drv.c b/drivers/staging/vboxvideo/vbox_drv.c
> index 6d0600c37c0c..e18642e5027e 100644
> --- a/drivers/staging/vboxvideo/vbox_drv.c
> +++ b/drivers/staging/vboxvideo/vbox_drv.c
> @@ -36,7 +36,7 @@
>   
>   #include "vbox_drv.h"
>   
> -int vbox_modeset = -1;
> +static int vbox_modeset = -1;
>   
>   MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
>   module_param_named(modeset, vbox_modeset, int, 0400);
> diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo/vbox_ttm.c
> index 34a905d40735..4eb410a2a1a8 100644
> --- a/drivers/staging/vboxvideo/vbox_ttm.c
> +++ b/drivers/staging/vboxvideo/vbox_ttm.c
> @@ -230,7 +230,7 @@ static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm)
>   	ttm_pool_unpopulate(ttm);
>   }
>   
> -struct ttm_bo_driver vbox_bo_driver = {
> +static struct ttm_bo_driver vbox_bo_driver = {
>   	.ttm_tt_create = vbox_ttm_tt_create,
>   	.ttm_tt_populate = vbox_ttm_tt_populate,
>   	.ttm_tt_unpopulate = vbox_ttm_tt_unpopulate,
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: vboxvideo: make a couple of symbols static Colin King <colin.king@canonical.com> - 2017-07-19 11:40 +0200
  Re: [PATCH] staging: vboxvideo: make a couple of symbols static Hans de Goede <hdegoede@redhat.com> - 2017-07-22 00:20 +0200
    Re: [PATCH] staging: vboxvideo: make a couple of symbols static Michael Thayer <michael.thayer@oracle.com> - 2017-07-22 09:30 +0200

csiph-web