Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1694018

Re: [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool

From Hans de Goede <hdegoede@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool
Date 2017-07-22 00:20 +0200
Message-ID <u5Or7-240-1@gated-at.bofh.it> (permalink)
References <tVs8x-8dV-7@gated-at.bofh.it> <u4c4y-4fj-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi,

On 17-07-17 13:04, Lee Jones wrote:
> On Fri, 23 Jun 2017, Hans de Goede wrote:
> 
>> The PMIC provides ACPI OpRegions which must be available for other
>> drivers' PS0 / PS3 methods early-on as such it must be builtin as the
>> Kconfig help text already states.
>>
>> Somehow its Kconfig option ended up being a tristate though, this fixes
>> this.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> Note, feel free to squash this in the original commit if you wish
> 
> Looks like the original commit is yet to be accepted.

The original commit is already in Linus' tree:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/mfd?id=de85d79f4aab67fe0537dd6e2c5d545b88239cc4

Regards,

Hans


> 
> Please ensure it's squashed in and resubmit.
> 
>> ---
>>   drivers/mfd/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 8533cb46a875..be962d128f31 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -476,7 +476,7 @@ config INTEL_SOC_PMIC_BXTWC
>>   	  on these systems.
>>   
>>   config INTEL_SOC_PMIC_CHTWC
>> -	tristate "Support for Intel Cherry Trail Whiskey Cove PMIC"
>> +	bool "Support for Intel Cherry Trail Whiskey Cove PMIC"
>>   	depends on ACPI && HAS_IOMEM && I2C=y && COMMON_CLK
>>   	depends on X86 || COMPILE_TEST
>>   	select MFD_CORE
> 

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a  bool Hans de Goede <hdegoede@redhat.com> - 2017-07-22 00:20 +0200

csiph-web