Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1692272

Re: [PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw()

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw()
Date Thu, 20 Jul 2017 01:40:01 +0200
Message-ID <u56Jr-7ff-3@gated-at.bofh.it> (permalink)
References <u4HBo-79O-19@gated-at.bofh.it>
X-Original-To gustavo@embeddedor.com
X-Mailer Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
MIME-Version 1.0
Content-Type Text/Plain; charset=us-ascii
Content-Transfer-Encoding 7bit
X-Greylist Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 19 Jul 2017 16:35:04 -0700 (PDT)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 13
Organization linux.* mail to news gateway
X-Original-Cc harish.patil@cavium.com, manish.chopra@cavium.com, Dept-GELinuxNICDev@cavium.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Wed, 19 Jul 2017 16:35:04 -0700 (PDT)
X-Original-Message-ID <20170719.163504.1972586469015417785.davem@davemloft.net>
X-Original-References <20170718204529.GA11448@embeddedgus>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1692272

Show key headers only | View raw


From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Tue, 18 Jul 2017 15:45:29 -0500

> Remove unnecessary static on local variable fw_dump_ops.
> Such variable is initialized before being used, on every
> execution path throughout the function. The static has no
> benefit and, removing it reduces the object file size.
> 
> This issue was detected using Coccinelle and the following semantic patch:
 ...
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Applied.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-07-18 22:50 +0200
  Re: [PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw() David Miller <davem@davemloft.net> - 2017-07-20 01:40 +0200

csiph-web