Re: [PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw()

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw()
Date	2017-07-20 01:40 +0200
Message-ID	<u56Jr-7ff-3@gated-at.bofh.it> (permalink)
References	<u4HBo-79O-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Tue, 18 Jul 2017 15:45:29 -0500

> Remove unnecessary static on local variable fw_dump_ops.
> Such variable is initialized before being used, on every
> execution path throughout the function. The static has no
> benefit and, removing it reduces the object file size.
> 
> This issue was detected using Coccinelle and the following semantic patch:
 ...
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-07-18 22:50 +0200
  Re: [PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw() David Miller <davem@davemloft.net> - 2017-07-20 01:40 +0200

csiph-web