[RFC PATCH 1/5] serial: arc: Remove __init marking from early write

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Jeffy Chen <jeffy.chen@rock-chips.com>
Newsgroups	linux.kernel
Subject	[RFC PATCH 1/5] serial: arc: Remove __init marking from early write
Date	Tue, 18 Jul 2017 06:40:02 +0200
Message-ID	<u4ssF-6bP-7@gated-at.bofh.it> (permalink)
References	<u4ssF-6bP-3@gated-at.bofh.it>
X-Original-To	linux-kernel@vger.kernel.org
X-263anti-Spam	KSV:0;
X-Mail-Delivery	1
X-Abs-Checked	4
X-Rl-Sender	jeffy.chen@rock-chips.com
X-Fst-To	linux-kernel@vger.kernel.org
X-Sender-IP	103.29.142.67
X-Login-Name	jeffy.chen@rock-chips.com
X-Unique-Tag	<774639d4dbc7973e8389b60f5ebf265e>
X-Sender	cjf@rock-chips.com
X-Mailer	git-send-email 2.1.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	gregkh@linuxfoundation.org, briannorris@chromium.org, dianders@chromium.org, peter@hurleysoftware.com, Jeffy Chen <jeffy.chen@rock-chips.com>, Jiri Slaby <jslaby@suse.com>, Vineet Gupta <vgupta@synopsys.com>, linux-serial@vger.kernel.org, linux-snps-arc@lists.infradead.org
X-Original-Date	Tue, 18 Jul 2017 12:29:59 +0800
X-Original-Message-ID	<1500352203-21513-2-git-send-email-jeffy.chen@rock-chips.com>
X-Original-References	<1500352203-21513-1-git-send-email-jeffy.chen@rock-chips.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1689681

Show key headers only | View raw

The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.

So remove the __init marking to avoid invalid memory access.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

 drivers/tty/serial/arc_uart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
index 5ac06fc..77fe306 100644
--- a/drivers/tty/serial/arc_uart.c
+++ b/drivers/tty/serial/arc_uart.c
@@ -549,8 +549,8 @@ static struct console arc_console = {
 	.data	= &arc_uart_driver
 };
 
-static __init void arc_early_serial_write(struct console *con, const char *s,
-					  unsigned int n)
+static void arc_early_serial_write(struct console *con, const char *s,
+				   unsigned int n)
 {
 	struct earlycon_device *dev = con->data;
 
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 1/5] serial: arc: Remove __init marking from early write Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-07-18 06:40 +0200
  Re: [RFC PATCH 1/5] serial: arc: Remove __init marking from early  write Greg KH <gregkh@linuxfoundation.org> - 2017-07-18 07:10 +0200
    Re: [RFC PATCH 1/5] serial: arc: Remove __init marking from early  write jeffy <jeffy.chen@rock-chips.com> - 2017-07-18 08:10 +0200

csiph-web