Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops
Date	2017-07-17 23:20 +0200
Message-ID	<u4lAS-1PS-15@gated-at.bofh.it> (permalink)
References	<u4k27-LB-25@gated-at.bofh.it> <u4l7Q-1qg-29@gated-at.bofh.it> <u4lrm-1Mq-131@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Andrew Lunn <andrew@lunn.ch>
Date: Mon, 17 Jul 2017 23:04:05 +0200

> On Mon, Jul 17, 2017 at 01:45:49PM -0700, David Miller wrote:
>> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>> Date: Mon, 17 Jul 2017 15:32:52 -0400
>> 
>> > Hi Andrew,
>> > 
>> > Andrew Lunn <andrew@lunn.ch> writes:
>> > 
>> >> I never liked this. I think it is architecturally wrong for the switch
>> >> to be poking around in the PHY. It should ask the PHY driver. This is
>> >> especially true for external PHYs which might not be a Marvell PHY.
>> > 
>> > I share the same concern. However this patch is just isolating the
>> > existing code so that we get rid of the last caps and flags and stop
>> > writing (without reading them first) arbitrary registers.
>> > 
>> > Once this portion is moved to the PHY driver, one can remove it from
>> > mv88e6xxx.
>> 
>> Seems a reasonable plan of action.
>> 
>> Andrew, do you agree?
> 
> Hi David
> 
> I just fear it will not get fixed, just put into a corner to
> fester. Having to fix it properly before these patches are merged
> provides some incentive.

If Vivien doesn't make good on his promises to do so, tell me and
I will revert all of these changes.

Ok?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-17 19:10 +0200
  Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops Andrew Lunn <andrew@lunn.ch> - 2017-07-17 21:30 +0200
    Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-17 21:40 +0200
      Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect  ops David Miller <davem@davemloft.net> - 2017-07-17 22:50 +0200
        Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops Andrew Lunn <andrew@lunn.ch> - 2017-07-17 23:10 +0200
          Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect  ops David Miller <davem@davemloft.net> - 2017-07-17 23:20 +0200

csiph-web