Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689394

Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops

Show all headers | View raw

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

> I never liked this. I think it is architecturally wrong for the switch
> to be poking around in the PHY. It should ask the PHY driver. This is
> especially true for external PHYs which might not be a Marvell PHY.

I share the same concern. However this patch is just isolating the
existing code so that we get rid of the last caps and flags and stop
writing (without reading them first) arbitrary registers.

Once this portion is moved to the PHY driver, one can remove it from
mv88e6xxx.

Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-17 19:10 +0200
  Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops Andrew Lunn <andrew@lunn.ch> - 2017-07-17 21:30 +0200
    Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-17 21:40 +0200
      Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect  ops David Miller <davem@davemloft.net> - 2017-07-17 22:50 +0200
        Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect ops Andrew Lunn <andrew@lunn.ch> - 2017-07-17 23:10 +0200
          Re: [PATCH net-next 11/12] net: dsa: mv88e6xxx: add Energy Detect  ops David Miller <davem@davemloft.net> - 2017-07-17 23:20 +0200

csiph-web