Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue

From	Craig Inches <craig@craiginches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue
Date	2017-07-17 20:00 +0200
Message-ID	<u4itj-8aw-7@gated-at.bofh.it> (permalink)
References	<u2lOF-6iL-3@gated-at.bofh.it> <u2lOF-6iL-9@gated-at.bofh.it> <u4ijE-85t-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 17, 2017 at 05:44:59PM +0000, Dilger, Andreas wrote:
> On Jul 12, 2017, at 03:03, Craig Inches <craig@craiginches.com> wrote:
> > 
> > This fixes a block statement which didnt end with */
> > 
> > Signed-off-by: Craig Inches <Craig@craiginches.com>
> > ---
> > drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h b/drivers/staging/lustre/include/linux/lnet/socklnd.h
> > index dd5bc0e46560..a1ae66ede7a8 100644
> > --- a/drivers/staging/lustre/include/linux/lnet/socklnd.h
> > +++ b/drivers/staging/lustre/include/linux/lnet/socklnd.h
> > @@ -76,7 +76,8 @@ struct ksock_msg {
> > 	__u64	ksm_zc_cookies[2];	/* Zero-Copy request/ACK cookie */
> > 	union {
> > 		struct ksock_lnet_msg lnetmsg; /* lnet message, it's empty if
> > -					  * it's NOOP */
> > +						* it's NOOP
> > +						*/
> 
> Rather than making the multi-line comments even more space consuming (I'm not a big
> fan of "*/ must be on a line by itself" since it wastes a lot of vertical space),
> I'd prefer to just shorten the comment, if possible, like:
> 
> 		struct ksock_lnet_msg lnetmsg; /* lnet message, empty if NOOP */

That makes sense, I believe the series has already made it to
staging-next, so not sure what the process would be to fix it up.

I am doing another set of style fixes which I can include this change
aswell.

Cheers,

Craig

Thread

[PATCH v2 4/4] Staging: Lustre Fix block statement style issue Craig Inches <Craig@craiginches.com> - 2017-07-12 11:10 +0200
  Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue "Dilger, Andreas" <andreas.dilger@intel.com> - 2017-07-17 19:50 +0200
    Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue Craig Inches <craig@craiginches.com> - 2017-07-17 20:00 +0200
      Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-17 20:30 +0200

csiph-web