Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689303

Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue

Show all headers | View raw

On Jul 12, 2017, at 03:03, Craig Inches <craig@craiginches.com> wrote:
> 
> This fixes a block statement which didnt end with */
> 
> Signed-off-by: Craig Inches <Craig@craiginches.com>
> ---
> drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h b/drivers/staging/lustre/include/linux/lnet/socklnd.h
> index dd5bc0e46560..a1ae66ede7a8 100644
> --- a/drivers/staging/lustre/include/linux/lnet/socklnd.h
> +++ b/drivers/staging/lustre/include/linux/lnet/socklnd.h
> @@ -76,7 +76,8 @@ struct ksock_msg {
> 	__u64	ksm_zc_cookies[2];	/* Zero-Copy request/ACK cookie */
> 	union {
> 		struct ksock_lnet_msg lnetmsg; /* lnet message, it's empty if
> -					  * it's NOOP */
> +						* it's NOOP
> +						*/

Rather than making the multi-line comments even more space consuming (I'm not a big
fan of "*/ must be on a line by itself" since it wastes a lot of vertical space),
I'd prefer to just shorten the comment, if possible, like:

		struct ksock_lnet_msg lnetmsg; /* lnet message, empty if NOOP */

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 4/4] Staging: Lustre Fix block statement style issue Craig Inches <Craig@craiginches.com> - 2017-07-12 11:10 +0200
  Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue "Dilger, Andreas" <andreas.dilger@intel.com> - 2017-07-17 19:50 +0200
    Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue Craig Inches <craig@craiginches.com> - 2017-07-17 20:00 +0200
      Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-17 20:30 +0200

csiph-web