Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1691644

Re: [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay

Show all headers | View raw

On Wed, 2017-07-19 at 17:55 +0530, Jaya Durga wrote:
> Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
[]
> diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c
[]
> @@ -28,7 +28,7 @@
>  
>  #define DRV_VERSION "2.10"
>  #define SYNTH_IO_EXTENT	0x04
> -#define SWAIT udelay(70)
> +#define SWAIT usleep_range(70, 150)

It'd probably be more sensible to remove this define as
SWAIT is used just once and use usleep_range directly.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range  is preferred over udelay Joe Perches <joe@perches.com> - 2017-07-19 14:40 +0200
  Re: [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range  is preferred over udelay Greg KH <gregkh@linuxfoundation.org> - 2017-07-19 14:50 +0200

csiph-web