Re: [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay
Date	2017-07-19 14:50 +0200
Message-ID	<u4WAq-bK-5@gated-at.bofh.it> (permalink)
References	<u4WqK-7Z-11@gated-at.bofh.it> <u4WqK-7Z-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 19, 2017 at 05:36:28AM -0700, Joe Perches wrote:
> On Wed, 2017-07-19 at 17:55 +0530, Jaya Durga wrote:
> > Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
> []
> > diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c
> []
> > @@ -28,7 +28,7 @@
> >  
> >  #define DRV_VERSION "2.10"
> >  #define SYNTH_IO_EXTENT	0x04
> > -#define SWAIT udelay(70)
> > +#define SWAIT usleep_range(70, 150)
> 
> It'd probably be more sensible to remove this define as
> SWAIT is used just once and use usleep_range directly.
> 

I asked for that last time :(

I guess I'll just reject this again...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range  is preferred over udelay Joe Perches <joe@perches.com> - 2017-07-19 14:40 +0200
  Re: [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range  is preferred over udelay Greg KH <gregkh@linuxfoundation.org> - 2017-07-19 14:50 +0200

csiph-web