Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690758

Re: [PATCH 1/2] MIPS: ralink: Fix build error due to missing header

Show all headers | View raw

On Tue, Jul 18, 2017 at 02:25:45PM +0100, Harvey Hunt wrote:

> Previously, <linux/module.h> was included before ralink_regs.h in all
> ralink files - leading to <linux/io.h> being implicitly included.
> 
> After commit 26dd3e4ff9ac ("MIPS: Audit and remove any unnecessary
> uses of module.h") removed the inclusion of module.h from multiple
> places, some ralink platforms failed to build with the following error:
> 
> In file included from arch/mips/ralink/mt7620.c:17:0:
> ./arch/mips/include/asm/mach-ralink/ralink_regs.h: In function ‘rt_sysc_w32’:
> ./arch/mips/include/asm/mach-ralink/ralink_regs.h:38:2: error: implicit declaration of function ‘__raw_writel’ [-Werror=implicit-function-declaration]
>   __raw_writel(val, rt_sysc_membase + reg);
>   ^
> ./arch/mips/include/asm/mach-ralink/ralink_regs.h: In function ‘rt_sysc_r32’:
> ./arch/mips/include/asm/mach-ralink/ralink_regs.h:43:2: error: implicit declaration of function ‘__raw_readl’ [-Werror=implicit-function-declaration]
>   return __raw_readl(rt_sysc_membase + reg);
> 
> Fix this by including <linux/io.h>.

Looks sensible, applied.  But I'm wondering why I don't see this in my
test builds.

  Ralf

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] MIPS: ralink: Fix build error due to missing header Harvey Hunt <harvey.hunt@imgtec.com> - 2017-07-18 15:30 +0200
  [PATCH 2/2] MIPS: ralink: mt7620: Add missing header Harvey Hunt <harvey.hunt@imgtec.com> - 2017-07-18 15:30 +0200
    Re: [PATCH 2/2] MIPS: ralink: mt7620: Add missing header Ralf Baechle <ralf@linux-mips.org> - 2017-07-19 00:10 +0200
  Re: [PATCH 1/2] MIPS: ralink: Fix build error due to missing header Ralf Baechle <ralf@linux-mips.org> - 2017-07-19 00:10 +0200
    Re: [PATCH 1/2] MIPS: ralink: Fix build error due to missing header Harvey Hunt <Harvey.Hunt@imgtec.com> - 2017-07-19 13:00 +0200

csiph-web