Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690752

Re: [PATCH 2/2] MIPS: ralink: mt7620: Add missing header

Show all headers | View raw

On Tue, Jul 18, 2017 at 02:25:46PM +0100, Harvey Hunt wrote:

> Fix a build error caused by not including <linux/bug.h>.
> 
> The following compilation errors are caused by the missing header:
> 
> arch/mips/ralink/mt7620.c: In function ‘mt7620_get_cpu_pll_rate’:
> arch/mips/ralink/mt7620.c:431:2: error: implicit declaration of function ‘WARN_ON’ [-Werror=implicit-function-declaration]
>   WARN_ON(div >= ARRAY_SIZE(mt7620_clk_divider));
>   ^
> arch/mips/ralink/mt7620.c: In function ‘mt7620_get_sys_rate’:
> arch/mips/ralink/mt7620.c:500:2: error: implicit declaration of function ‘WARN’ [-Werror=implicit-function-declaration]
>   if (WARN(!div, "invalid divider for OCP ratio %u", ocp_ratio))
>   ^
> arch/mips/ralink/mt7620.c: In function ‘mt7620_dram_init’:
> arch/mips/ralink/mt7620.c:619:3: error: implicit declaration of function ‘BUG’ [-Werror=implicit-function-declaration]
>    BUG();
>    ^
> cc1: some warnings being treated as errors
> scripts/Makefile.build:302: recipe for target 'arch/mips/ralink/mt7620.o' failed
> 
> Signed-off-by: Harvey Hunt <harvey.hunt@imgtec.com>
> Cc: John Crispin <john@phrozen.org>
> Cc: linux-mips@linux-mips.org
> Cc: linux-kernel@vger.kernel.org

Same comment as for the previous patch - looks sensible, so applied.  But
I'm wondering why I don't see this in test builds.

  Ralf

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] MIPS: ralink: Fix build error due to missing header Harvey Hunt <harvey.hunt@imgtec.com> - 2017-07-18 15:30 +0200
  [PATCH 2/2] MIPS: ralink: mt7620: Add missing header Harvey Hunt <harvey.hunt@imgtec.com> - 2017-07-18 15:30 +0200
    Re: [PATCH 2/2] MIPS: ralink: mt7620: Add missing header Ralf Baechle <ralf@linux-mips.org> - 2017-07-19 00:10 +0200
  Re: [PATCH 1/2] MIPS: ralink: Fix build error due to missing header Ralf Baechle <ralf@linux-mips.org> - 2017-07-19 00:10 +0200
    Re: [PATCH 1/2] MIPS: ralink: Fix build error due to missing header Harvey Hunt <Harvey.Hunt@imgtec.com> - 2017-07-19 13:00 +0200

csiph-web