Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred

Path	csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	jeffy <jeffy.chen@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred
Date	Tue, 18 Jul 2017 15:20:01 +0200
Message-ID	<u4AzT-2Sx-7@gated-at.bofh.it> (permalink)
References	<u4q7w-4KD-1@gated-at.bofh.it> <u4uut-7ol-13@gated-at.bofh.it> <u4vgS-7Vc-21@gated-at.bofh.it> <u4vJU-8k9-13@gated-at.bofh.it> <u4wmC-51-15@gated-at.bofh.it> <u4x90-CI-37@gated-at.bofh.it> <u4xiH-HH-43@gated-at.bofh.it> <u4xsn-Lp-39@gated-at.bofh.it> <u4zXc-2qo-19@gated-at.bofh.it>
X-263anti-Spam	KSV:0;BIG:0;
X-Mail-Delivery	1
X-Addr-Checked4	1
X-Abs-Checked	1
X-Ske-Checked	1
X-Antispam-Level	2
X-Rl-Sender	jeffy.chen@rock-chips.com
X-Fst-To	oneukum@suse.com
X-Sender-IP	103.29.142.67
X-Login-Name	jeffy.chen@rock-chips.com
X-Unique-Tag	<314903c6180299d7f672376cabf53fd1>
X-Sender	cjf@rock-chips.com
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	briannorris@chromium.org, dianders@chromium.org, Johan Hedberg <johan.hedberg@gmail.com>, xiyou.wangcong@gmail.com, "Gustavo F. Padovan" <gustavo@padovan.org>, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 18 Jul 2017 21:13:21 +0800
X-Original-Message-ID	<596E0971.8030507@rock-chips.com>
X-Original-References	<1500343579-9831-1-git-send-email-jeffy.chen@rock-chips.com> <6E21F79E-93AA-4461-BA6B-67715501714F@holtmann.org> <1500363015.16072.5.camel@suse.com> <596DC200.1080006@rock-chips.com> <1500367310.502.0.camel@suse.com> <596DD6AE.2030704@rock-chips.com> <1500370901.502.6.camel@suse.com> <596DDB63.6010206@rock-chips.com> <1500380982.502.12.camel@suse.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1690253

Show key headers only | View raw

Hi Oliver,

On 07/18/2017 08:29 PM, Oliver Neukum wrote:
> Am Dienstag, den 18.07.2017, 17:56 +0800 schrieb jeffy:
>> Hi Oliver,
>>
>>> I think that as soon as one URB fails, you should not even try
>>> to submit any other deferred URBs. You are taking one out from
>>> the middle of a sequence. That cannot be right.
>> ok, that make sense.
>>
>> new patch sent :)
>
> Where to?
>
sorry, just noticed that you're not in the auto-generated CC list by 
patman...i'll resend it, thanks:)

> 	Regards
> 		Oliver
>
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-07-18 04:10 +0200
  Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred Marcel Holtmann <marcel@holtmann.org> - 2017-07-18 08:50 +0200
    Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in  play_deferred Oliver Neukum <oneukum@suse.com> - 2017-07-18 09:40 +0200
      Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred jeffy <jeffy.chen@rock-chips.com> - 2017-07-18 10:10 +0200
        Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in  play_deferred Oliver Neukum <oneukum@suse.com> - 2017-07-18 10:50 +0200
          Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred jeffy <jeffy.chen@rock-chips.com> - 2017-07-18 11:40 +0200
            Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in  play_deferred Oliver Neukum <oneukum@suse.com> - 2017-07-18 11:50 +0200
              Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred jeffy <jeffy.chen@rock-chips.com> - 2017-07-18 12:00 +0200
                Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in  play_deferred Oliver Neukum <oneukum@suse.com> - 2017-07-18 14:40 +0200
                Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred jeffy <jeffy.chen@rock-chips.com> - 2017-07-18 15:20 +0200

csiph-web