Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689961

Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred

From Oliver Neukum <oneukum@suse.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred
Date 2017-07-18 11:50 +0200
Message-ID <u4xiH-HH-43@gated-at.bofh.it> (permalink)
References (1 earlier) <u4uut-7ol-13@gated-at.bofh.it> <u4vgS-7Vc-21@gated-at.bofh.it> <u4vJU-8k9-13@gated-at.bofh.it> <u4wmC-51-15@gated-at.bofh.it> <u4x90-CI-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Am Dienstag, den 18.07.2017, 17:36 +0800 schrieb jeffy:
> Hi Oliver,
> 
> On 07/18/2017 04:41 PM, Oliver Neukum wrote:
> > 
> > Am Dienstag, den 18.07.2017, 16:08 +0800 schrieb jeffy:
> > > 
> > > > 
> > > > I am afraid not. We cannot silently drop one part of a transmission.
> > > > I am afraid that the correct algorithm, if we encounter an error at
> > > > that stage, is to abort the operation and report an error.
> > > > 
> > > so i should break the loop when error happens right?
> > 
> > Yes
> ok, i'll do that.
> > 
> > 
> > > 
> > > 
> > > and i uploaded 2 version of patches, which one do you prefer to go on?
> > 
> > Where to?
> https://patchwork.kernel.org/patch/9847037
> and
> https://patchwork.kernel.org/patch/9846617

I think that as soon as one URB fails, you should not even try
to submit any other deferred URBs. You are taking one out from
the middle of a sequence. That cannot be right.

	Regards
		Oliver

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-07-18 04:10 +0200
  Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred Marcel Holtmann <marcel@holtmann.org> - 2017-07-18 08:50 +0200
    Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in  play_deferred Oliver Neukum <oneukum@suse.com> - 2017-07-18 09:40 +0200
      Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred jeffy <jeffy.chen@rock-chips.com> - 2017-07-18 10:10 +0200
        Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in  play_deferred Oliver Neukum <oneukum@suse.com> - 2017-07-18 10:50 +0200
          Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred jeffy <jeffy.chen@rock-chips.com> - 2017-07-18 11:40 +0200
            Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in  play_deferred Oliver Neukum <oneukum@suse.com> - 2017-07-18 11:50 +0200
              Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred jeffy <jeffy.chen@rock-chips.com> - 2017-07-18 12:00 +0200
                Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in  play_deferred Oliver Neukum <oneukum@suse.com> - 2017-07-18 14:40 +0200
                Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred jeffy <jeffy.chen@rock-chips.com> - 2017-07-18 15:20 +0200

csiph-web