Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments"

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments"
Date	2017-07-18 15:00 +0200
Message-ID	<u4Agy-2wZ-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <u2sds-1H6-29@gated-at.bofh.it> <u4fF8-6ob-21@gated-at.bofh.it> <u4w3g-8qp-7@gated-at.bofh.it> <u4xC2-146-25@gated-at.bofh.it> <u4y56-1ed-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Jul 18, 2017 at 12:36:29PM +0200, Johan Hovold wrote:
> On Tue, Jul 18, 2017 at 11:06:55AM +0100, Mark Brown wrote:

> > Reverts shouldn't be special - they're just regular patches and should
> > have sensible changelogs like any others.

> Stating that you're reverting a commit and which commit that is is in
> the summary is arguable sensible (of course, you still also need further
> details in the commit message body itself describing why it was needed).

> Check the logs and you'll see that we have a ton of "Revert <reverted
> commit summary>" for various subsystems. In fact, it seems to be by far
> the most common summary for direct reverts.

The easily findable ones are, and it doesn't mean it's good practice -
reverts seem to attract particularly bad commit messages in general, not
just the subject lines, and I happen to have a pre-canned response for
this so...

Thread

[PATCH 1/2] ASoC: fix pcm-creation regression Johan Hovold <johan@kernel.org> - 2017-07-12 18:00 +0200
  [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Johan Hovold <johan@kernel.org> - 2017-07-12 18:00 +0200
    Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Linus Walleij <linus.walleij@linaro.org> - 2017-07-14 15:40 +0200
      Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Johan Hovold <johan@kernel.org> - 2017-07-17 10:10 +0200
    Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Mark Brown <broonie@kernel.org> - 2017-07-17 17:00 +0200
      Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Johan Hovold <johan@kernel.org> - 2017-07-18 10:30 +0200
        Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Mark Brown <broonie@kernel.org> - 2017-07-18 12:10 +0200
          Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Johan Hovold <johan@kernel.org> - 2017-07-18 12:40 +0200
            Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Mark Brown <broonie@kernel.org> - 2017-07-18 15:00 +0200
    Applied "ASoC: ux500: Restore platform DAI assignments" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-07-17 18:10 +0200
  Re: [PATCH 1/2] ASoC: fix pcm-creation regression Linus Walleij <linus.walleij@linaro.org> - 2017-07-14 15:40 +0200
    Re: [PATCH 1/2] ASoC: fix pcm-creation regression Johan Hovold <johan@kernel.org> - 2017-07-17 10:10 +0200
  Applied "ASoC: fix pcm-creation regression" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-07-17 18:10 +0200

csiph-web