Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1688740

Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments"

Show all headers | View raw

On Fri, Jul 14, 2017 at 03:36:57PM +0200, Linus Walleij wrote:
> On Wed, Jul 12, 2017 at 5:55 PM, Johan Hovold <johan@kernel.org> wrote:
> 
> > This reverts commit f1013cdeeeb9 ("ASoC: ux500: drop platform DAI
> > assignments"), which seems to have been based on a misunderstanding and
> > prevents the platform driver callbacks from being made (e.g. to
> > preallocate DMA memory).
> >
> > The real culprit for the warnings about attempts to create duplicate
> > procfs entries was commit 99b04f4c4051 ("ASoC: add Component level
> > pcm_new/pcm_free" that broke PCM creation on systems that use more than
> > one platform component.
> >
> > Fixes: f1013cdeeeb9 ("ASoC: ux500: drop platform DAI assignments")
> > Cc: stable <stable@vger.kernel.org>     # 4.11
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Tested-by: Linus Walleij <linus.walleij@linaro.org>
> 
> These static assignments should go away, but not for the wrong reason.
> So this patch is fully in order given the source of the bug.

I assume you'll still need the of-related bits though (platform_of_node)
even if you eventually make this driver use DT-instantiation only.

Thanks again,
Johan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] ASoC: fix pcm-creation regression Johan Hovold <johan@kernel.org> - 2017-07-12 18:00 +0200
  [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Johan Hovold <johan@kernel.org> - 2017-07-12 18:00 +0200
    Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Linus Walleij <linus.walleij@linaro.org> - 2017-07-14 15:40 +0200
      Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Johan Hovold <johan@kernel.org> - 2017-07-17 10:10 +0200
    Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Mark Brown <broonie@kernel.org> - 2017-07-17 17:00 +0200
      Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Johan Hovold <johan@kernel.org> - 2017-07-18 10:30 +0200
    Applied "ASoC: ux500: Restore platform DAI assignments" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-07-17 18:10 +0200
  Re: [PATCH 1/2] ASoC: fix pcm-creation regression Linus Walleij <linus.walleij@linaro.org> - 2017-07-14 15:40 +0200
    Re: [PATCH 1/2] ASoC: fix pcm-creation regression Johan Hovold <johan@kernel.org> - 2017-07-17 10:10 +0200
  Applied "ASoC: fix pcm-creation regression" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-07-17 18:10 +0200

csiph-web