Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690275

Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Jul 18, 2017 at 05:49:23PM +0800, sean.wang@mediatek.com wrote:

> +	if (!info->modeset_mask) {
> +		dev_err(&rdev->dev, "regulator %s doesn't support set_mode\n",
> +			info->desc.name);
> +		return -EINVAL;
> +	}

This is mostly fine but the mode operations all have this code - if the
regulator doesn't have modesetting facilities it just shouldn't have
the ops so the core can handle things in a standard fashion.  It'd mean
defining a separate set of operations for those regulators but that's
fine.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/9] Add PMIC support to MediaTek MT7622 SoC <sean.wang@mediatek.com> - 2017-07-18 11:50 +0200
  [PATCH v2 8/9] soc: mediatek: pwrap: add support for MT7622 SoC <sean.wang@mediatek.com> - 2017-07-18 12:00 +0200
  [PATCH v2 3/9] regulator: mt6380: Add support for MT6380 <sean.wang@mediatek.com> - 2017-07-18 12:00 +0200
    Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380 Mark Brown <broonie@kernel.org> - 2017-07-18 15:40 +0200
  [PATCH v2 7/9] soc: mediatek: pwrap: add MediaTek MT6380 as one slave of pwrap <sean.wang@mediatek.com> - 2017-07-18 12:00 +0200
  [PATCH v2 9/9] soc: mediatek: pwrap: fixup warnings from coding style <sean.wang@mediatek.com> - 2017-07-18 12:00 +0200
    Re: [PATCH v2 9/9] soc: mediatek: pwrap: fixup warnings from coding  style Yingjoe Chen <yingjoe.chen@mediatek.com> - 2017-07-18 18:30 +0200
      Re: [PATCH v2 9/9] soc: mediatek: pwrap: fixup warnings from coding  style Joe Perches <joe@perches.com> - 2017-07-18 18:40 +0200
  [PATCH v2 1/9] dt-bindings: arm: mediatek: add MT7622 string to the PMIC wrapper doc <sean.wang@mediatek.com> - 2017-07-18 12:00 +0200
    Re: [PATCH v2 1/9] dt-bindings: arm: mediatek: add MT7622 string to  the PMIC wrapper doc Yingjoe Chen <yingjoe.chen@mediatek.com> - 2017-07-18 18:10 +0200
      Re: [PATCH v2 1/9] dt-bindings: arm: mediatek: add MT7622 string to  the PMIC wrapper doc Sean Wang <sean.wang@mediatek.com> - 2017-07-19 05:00 +0200
  [PATCH v2 4/9] soc: mediatek: pwrap: add pwrap_read32 for reading in 32-bit mode <sean.wang@mediatek.com> - 2017-07-18 12:00 +0200
  [PATCH v2 6/9] soc: mediatek: pwrap: update pwrap_init without slave programming <sean.wang@mediatek.com> - 2017-07-18 12:00 +0200
  [PATCH v2 5/9] soc: mediatek: pwrap: add pwrap_write32 for writing in 32-bit mode <sean.wang@mediatek.com> - 2017-07-18 12:00 +0200

csiph-web