Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1688730
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/4] staging: lustre: obdclass: constify attribute_group structures. |
| Date | 2017-07-17 09:50 +0200 |
| Message-ID | <u48X0-26x-5@gated-at.bofh.it> (permalink) |
| References | <u474R-Uc-9@gated-at.bofh.it> <u47ez-Xp-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Sorry for noise. Please ignore this. This change should not be separate.
~arvind
On Monday 17 July 2017 11:19 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> index bc19f19..ba41983 100644
> --- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> +++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> @@ -1031,7 +1031,7 @@ static void obd_sysfs_release(struct kobject *kobj)
> };
>
> int lprocfs_obd_setup(struct obd_device *obd, struct lprocfs_vars *list,
> - struct attribute_group *attrs)
> + const struct attribute_group *attrs)
> {
> int rc = 0;
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] constify lustre attribute_group structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 07:50 +0200
[PATCH 1/4] staging: lustre: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 07:50 +0200
[PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 07:50 +0200
Re: [PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 09:50 +0200
Re: [PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 09:50 +0200
[PATCH 2/4] staging: lustre: ldlm: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 08:00 +0200
Re: [PATCH 2/4] staging: lustre: ldlm: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 09:50 +0200
[PATCH 4/4] staging: lustre: obdclass: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 08:00 +0200
Re: [PATCH 4/4] staging: lustre: obdclass: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 09:50 +0200
Re: [PATCH 0/4] constify lustre attribute_group structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 09:50 +0200
csiph-web