Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1688732
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/4] staging: lustre: ldlm: constify attribute_group structures. |
| Date | 2017-07-17 09:50 +0200 |
| Message-ID | <u48X0-26x-19@gated-at.bofh.it> (permalink) |
| References | <u474R-Uc-9@gated-at.bofh.it> <u47ex-Xp-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Sorry for noise. Please ignore this.
~arvind
On Monday 17 July 2017 11:18 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c b/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c
> index fff930f..e0c3e5d 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c
> @@ -926,7 +926,7 @@ static ssize_t cancel_unused_locks_before_replay_store(struct kobject *kobj,
> NULL,
> };
>
> -static struct attribute_group ldlm_attr_group = {
> +static const struct attribute_group ldlm_attr_group = {
> .attrs = ldlm_attrs,
> };
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] constify lustre attribute_group structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 07:50 +0200
[PATCH 1/4] staging: lustre: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 07:50 +0200
[PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 07:50 +0200
Re: [PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 09:50 +0200
Re: [PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 09:50 +0200
[PATCH 2/4] staging: lustre: ldlm: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 08:00 +0200
Re: [PATCH 2/4] staging: lustre: ldlm: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 09:50 +0200
[PATCH 4/4] staging: lustre: obdclass: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 08:00 +0200
Re: [PATCH 4/4] staging: lustre: obdclass: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 09:50 +0200
Re: [PATCH 0/4] constify lustre attribute_group structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 09:50 +0200
csiph-web