Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1688722

Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events
Date Mon, 17 Jul 2017 09:40:01 +0200
Message-ID <u48Nj-232-3@gated-at.bofh.it> (permalink)
References <u3bNf-600-11@gated-at.bofh.it> <u3czE-6A0-13@gated-at.bofh.it>
X-Original-To Andi Kleen <andi@firstfloor.org>
Dmarc-Filter OpenDMARC Filter v1.3.2 mx1.redhat.com E96F65F7B0
Authentication-Results ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com
Dkim-Filter OpenDKIM Filter v2.11.0 mx1.redhat.com E96F65F7B0
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.8.3 (2017-05-23)
X-Scanned-By MIMEDefang 2.79 on 10.5.11.14
X-Greylist Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 17 Jul 2017 07:38:54 +0000 (UTC)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 19
Organization linux.* mail to news gateway
X-Original-Cc Jiri Olsa <jolsa@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>, lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Kan Liang <kan.liang@intel.com>
X-Original-Date Mon, 17 Jul 2017 09:38:51 +0200
X-Original-Message-ID <20170717073851.GA22046@krava>
X-Original-References <20170714163551.19459-1-jolsa@kernel.org> <87d193lyqe.fsf@firstfloor.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1688722

Show key headers only | View raw


On Fri, Jul 14, 2017 at 10:22:49AM -0700, Andi Kleen wrote:
> Jiri Olsa <jolsa@kernel.org> writes:
> >
> > Setting the reset field to 0 for freq events.
> 
> Looks good to me.
> 
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
> 
> BTW I suspect there's a related bug that
> 
> perf record -e '{cycles:pp,branches}:S' ..
> 
> would enable multi record PEBS, even though it shouldn't because
> we need the PMI to read the other events.

thanks, I'll check on that

jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] perf/x86/intel: Fix debug_store reset field for freq events Jiri Olsa <jolsa@kernel.org> - 2017-07-14 18:40 +0200
  Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events Andi Kleen <andi@firstfloor.org> - 2017-07-14 19:30 +0200
    Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq  events Jiri Olsa <jolsa@redhat.com> - 2017-07-17 09:40 +0200
    Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq  events Jiri Olsa <jolsa@redhat.com> - 2017-07-17 13:40 +0200
      Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq  events Andi Kleen <andi@firstfloor.org> - 2017-07-17 20:10 +0200

csiph-web