Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1688945

Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events

Show all headers | View raw

On Fri, Jul 14, 2017 at 10:22:49AM -0700, Andi Kleen wrote:
> Jiri Olsa <jolsa@kernel.org> writes:
> >
> > Setting the reset field to 0 for freq events.
> 
> Looks good to me.
> 
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
> 
> BTW I suspect there's a related bug that
> 
> perf record -e '{cycles:pp,branches}:S' ..
> 
> would enable multi record PEBS, even though it shouldn't because
> we need the PMI to read the other events.

there's PERF_SAMPLE_READ om cycles's sample_type for this example
so it won't pass the x86_pmu::free_running_flags filter

also PERF_SAMPLE_TIME and PERF_SAMPLE_PERIOD will be set
in your example which will prevent that, but those
could be unset via record's '-c xxxx' and '--no-timestamp'

jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf/x86/intel: Fix debug_store reset field for freq events Jiri Olsa <jolsa@kernel.org> - 2017-07-14 18:40 +0200
  Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events Andi Kleen <andi@firstfloor.org> - 2017-07-14 19:30 +0200
    Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq  events Jiri Olsa <jolsa@redhat.com> - 2017-07-17 09:40 +0200
    Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq  events Jiri Olsa <jolsa@redhat.com> - 2017-07-17 13:40 +0200
      Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq  events Andi Kleen <andi@firstfloor.org> - 2017-07-17 20:10 +0200

csiph-web