Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

From	Daniel Micay <danielmicay@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] Please pull NFS client changes for Linux 4.13
Date	2017-07-14 23:00 +0200
Message-ID	<u3fQR-eC-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <u39Lt-4DQ-9@gated-at.bofh.it> <u3e8p-7II-5@gated-at.bofh.it> <u3eUN-82b-3@gated-at.bofh.it> <u3eUN-82b-1@gated-at.bofh.it> <u3fxw-6x-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> My initial patch used strlcpy there, because I wasn't aware of strscpy
> before it was suggested:
> 
> http://www.openwall.com/lists/kernel-hardening/2017/05/04/11
> 
> I was wrong to move it to strscpy. It could be switched back to
> strlcpy
> again unless the kernel considers the count parameter to be a
> guarantee
> that could be leveraged in the future. Using the fortified strlen +
> memcpy would provide the improvement that strscpy was meant to provide
> there over strlcpy.

Similarly, the FORTIFY_SOURCE strcat uses strlcat with the assumption
that the count parameter is a limit, not a guarantee for a optimization.
There's only a C implementation and it currently doesn't, but if it's
meant to be a guarantee then the strcat needs to be changed too.

I'll make a fix moving away both from the existing functions.

Thread

[GIT PULL] Please pull NFS client changes for Linux 4.13 Anna Schumaker <schumaker.anna@gmail.com> - 2017-07-13 23:20 +0200
  Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-13 23:50 +0200
    Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Christoph Hellwig <hch@infradead.org> - 2017-07-14 09:10 +0200
      Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Anna Schumaker <schumaker.anna@gmail.com> - 2017-07-14 13:40 +0200
  Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Dave Jones <davej@codemonkey.org.uk> - 2017-07-14 16:30 +0200
    Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 "J. Bruce Fields" <bfields@fieldses.org> - 2017-07-14 18:40 +0200
    Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-14 21:10 +0200
      Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Dave Jones <davej@codemonkey.org.uk> - 2017-07-14 21:50 +0200
      Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-14 22:00 +0200
        Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Andrey Rybainin <ryabinin.a.a@gmail.com> - 2017-07-14 22:30 +0200
        Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Daniel Micay <danielmicay@gmail.com> - 2017-07-14 22:40 +0200
          Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Daniel Micay <danielmicay@gmail.com> - 2017-07-14 23:00 +0200
          Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-14 23:00 +0200
            Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Daniel Micay <danielmicay@gmail.com> - 2017-07-14 23:10 +0200
              Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Daniel Micay <danielmicay@gmail.com> - 2017-07-14 23:10 +0200
        Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Daniel Micay <danielmicay@gmail.com> - 2017-07-15 02:00 +0200
    Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Dave Jones <davej@codemonkey.org.uk> - 2017-07-16 23:20 +0200
      Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Trond Myklebust <trondmy@primarydata.com> - 2017-07-17 01:00 +0200
        Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 "davej@codemonkey.org.uk" <davej@codemonkey.org.uk> - 2017-07-17 05:10 +0200
          Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-17 21:10 +0200

csiph-web