Re: [PATCH 3/3] fat: fix quoted string splits

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] fat: fix quoted string splits
Date	2017-07-16 17:40 +0200
Message-ID	<u3TOi-SL-11@gated-at.bofh.it> (permalink)
References	(1 earlier) <u3hSG-1OU-7@gated-at.bofh.it> <u3k4b-3a5-31@gated-at.bofh.it> <u3mIF-56P-1@gated-at.bofh.it> <u3S5Q-86e-5@gated-at.bofh.it> <u3Tlh-Ga-61@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jul 16, 2017 at 6:06 PM, Joe Perches <joe@perches.com> wrote:
> On Sun, 2017-07-16 at 16:46 +0300, Andy Shevchenko wrote:
>> On Sat, Jul 15, 2017 at 7:18 AM, Joe Perches <joe@perches.com> wrote:

>> As much as it adds 'error, ' at the beginning of message. I can't
>> consider this a bad idea.
>
> Adding "error" to KERN_ERR output is unnecessary
> and if really desired, should be done by dmesg
> or equivalent.

Shouldn't be fixed in the function itself (__fat_fs_error())?

Anyway, this discussion is obviously for a separate change. The
original patch looks okay.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] fat: fix quoted string splits Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2017-07-15 01:10 +0200
  Re: [PATCH 3/3] fat: fix quoted string splits Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-15 03:30 +0200
    Re: [PATCH 3/3] fat: fix quoted string splits Joe Perches <joe@perches.com> - 2017-07-15 06:20 +0200
      Re: [PATCH 3/3] fat: fix quoted string splits Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-16 15:50 +0200
        Re: [PATCH 3/3] fat: fix quoted string splits Joe Perches <joe@perches.com> - 2017-07-16 17:10 +0200
          Re: [PATCH 3/3] fat: fix quoted string splits Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-16 17:40 +0200

csiph-web