Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685795

Re: [PATCH v3 6/7] libsas: add wait-complete support to sync discovery event

Show all headers | View raw

On 10/07/2017 08:06, Yijing Wang wrote:
>
>  static void sas_chain_event(int event, unsigned long *pending,
> @@ -592,9 +596,9 @@ int sas_discover_event(struct asd_sas_port *port, enum discover_event ev)
>  {
>  	struct sas_discovery *disc;
>
> +	disc = &port->disc;
>  	if (!port)
>  		return 0;
> -	disc = &port->disc;
>
>  	BUG_ON(ev >= DISC_NUM_EVENTS);
>
> diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
> index 570b2cb..9d26c28 1

I was just looking through the code and I noticed this, above. Is there 
a specific reason to move the NULL check, or was it modified accidentally?

I mean, if port is NULL I don't think we would get as far as checking it 
as we would have already de-referenced it.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/7] Enhance libsas hotplug feature Yijing Wang <wangyijing@huawei.com> - 2017-07-10 09:10 +0200
  [PATCH v3 4/7] libsas: add sas event wait-complete support Yijing Wang <wangyijing@huawei.com> - 2017-07-10 09:10 +0200
    Re: [PATCH v3 4/7] libsas: add sas event wait-complete support Hannes Reinecke <hare@suse.de> - 2017-07-14 09:00 +0200
      Re: [PATCH v3 4/7] libsas: add sas event wait-complete support wangyijing <wangyijing@huawei.com> - 2017-07-14 09:50 +0200
      Re: [PATCH v3 4/7] libsas: add sas event wait-complete support John Garry <john.garry@huawei.com> - 2017-07-14 10:50 +0200
  [PATCH v3 6/7] libsas: add wait-complete support to sync discovery event Yijing Wang <wangyijing@huawei.com> - 2017-07-10 09:10 +0200
    Re: [PATCH v3 6/7] libsas: add wait-complete support to sync  discovery event John Garry <john.garry@huawei.com> - 2017-07-12 16:00 +0200
      Re: [PATCH v3 6/7] libsas: add wait-complete support to sync  discovery event wangyijing <wangyijing@huawei.com> - 2017-07-13 04:30 +0200
    Re: [PATCH v3 6/7] libsas: add wait-complete support to sync  discovery event Hannes Reinecke <hare@suse.de> - 2017-07-14 09:00 +0200
  [PATCH v3 3/7] libsas: Use new workqueue to run sas event Yijing Wang <wangyijing@huawei.com> - 2017-07-10 09:10 +0200
    Re: [PATCH v3 3/7] libsas: Use new workqueue to run sas event Hannes Reinecke <hare@suse.de> - 2017-07-14 08:50 +0200
  Re: [PATCH v3 0/7] Enhance libsas hotplug feature John Garry <john.garry@huawei.com> - 2017-07-12 12:10 +0200
    Re: [PATCH v3 0/7] Enhance libsas hotplug feature Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-12 14:00 +0200
    Re: [PATCH v3 0/7] Enhance libsas hotplug feature wangyijing <wangyijing@huawei.com> - 2017-07-13 03:30 +0200
    Re: [PATCH v3 0/7] Enhance libsas hotplug feature wangyijing <wangyijing@huawei.com> - 2017-07-13 03:40 +0200
      Re: [PATCH v3 0/7] Enhance libsas hotplug feature John Garry <john.garry@huawei.com> - 2017-07-13 10:10 +0200
        Re: [PATCH v3 0/7] Enhance libsas hotplug feature wangyijing <wangyijing@huawei.com> - 2017-07-13 10:50 +0200
  Re: [PATCH v3 0/7] Enhance libsas hotplug feature wangyijing <wangyijing@huawei.com> - 2017-07-14 10:30 +0200

csiph-web