Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685471

RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation

Show all headers | View raw

> -----Original Message-----
> From: Gerd Hoffmann [mailto:kraxel@redhat.com]
> Sent: Tuesday, July 11, 2017 2:08 PM
> To: Zhang, Tina <tina.zhang@intel.com>; alex.williamson@redhat.com;
> chris@chris-wilson.co.uk; zhenyuw@linux.intel.com; Lv, Zhiyuan
> <zhiyuan.lv@intel.com>; Wang, Zhi A <zhi.a.wang@intel.com>; Tian, Kevin
> <kevin.tian@intel.com>; daniel@ffwll.ch; kwankhede@nvidia.com
> Cc: intel-gfx@lists.freedesktop.org; intel-gvt-dev@lists.freedesktop.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation
> 
> > +/**
> > + * VFIO_DEVICE_QUERY_GFX_PLANE - _IOW(VFIO_TYPE, VFIO_BASE + 14,
> > + *                           struct vfio_device_query_gfx_plane)
> > + * Return: 0 on success, -errno on failure.
> > + */
> > +
> > +struct vfio_device_gfx_plane_info {
> > +	__u64 start;
> > +	__u64 drm_format_mod;
> > +	__u32 drm_format;
> > +	__u32 width;
> > +	__u32 height;
> > +	__u32 stride;
> > +	__u32 size;
> > +	__u32 x_pos;
> > +	__u32 y_pos;
> > +};
> 
> Do we want keep that as separate struct?  Given we now have only a single
> struct using that as sub-struct it looks pointless, at least from a API point of view.
> Does the driver use the struct internally?
Driver has another struct which is super-set of these fields. Yes, we can move all these fields into struct vfio_device_query_gfx_plane. Also, we can remove some of these fields which may seem useless for user mode.
Thanks.

Tina
> 
> > +
> > +struct vfio_device_query_gfx_plane {
> > +	__u32 argsz;
> > +	__u32 flags;
> > +	struct vfio_device_gfx_plane_info plane_info;
> > +	__u32 plane_type;
> > +	__s32 fd; /* dma-buf fd */
> > +	__u32 plane_id;
> 
> What is plane_id?
I cannot figure out the mean of plane_id either. If I remember correctly, it was asked by region usage. Of course, if no one needs it, I'd like to remove it.
Thanks.

Tina

> 
> cheers,
>   Gerd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v10] vfio: ABI for mdev display dma-buf operation Tina Zhang <tina.zhang@intel.com> - 2017-07-06 00:40 +0200
  Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Kirti Wankhede <kwankhede@nvidia.com> - 2017-07-06 16:10 +0200
    Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Gerd Hoffmann <kraxel@redhat.com> - 2017-07-11 08:20 +0200
      Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Daniel Vetter <daniel@ffwll.ch> - 2017-07-11 11:20 +0200
        RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation "Zhang, Tina" <tina.zhang@intel.com> - 2017-07-12 04:40 +0200
          Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Daniel Vetter <daniel@ffwll.ch> - 2017-07-12 09:50 +0200
            Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Kirti Wankhede <kwankhede@nvidia.com> - 2017-07-12 14:50 +0200
              RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation "Zhang, Tina" <tina.zhang@intel.com> - 2017-07-14 03:40 +0200
                Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Kirti Wankhede <kwankhede@nvidia.com> - 2017-07-14 12:20 +0200
                Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Gerd Hoffmann <kraxel@redhat.com> - 2017-07-14 14:10 +0200
                Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Kirti Wankhede <kwankhede@nvidia.com> - 2017-07-14 14:20 +0200
                Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Gerd Hoffmann <kraxel@redhat.com> - 2017-07-17 13:10 +0200
              Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Gerd Hoffmann <kraxel@redhat.com> - 2017-07-14 12:10 +0200
                Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Kirti Wankhede <kwankhede@nvidia.com> - 2017-07-14 12:20 +0200
                Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Gerd Hoffmann <kraxel@redhat.com> - 2017-07-14 14:20 +0200
        Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Zhenyu Wang <zhenyuw@linux.intel.com> - 2017-07-12 05:30 +0200
    RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation "Zhang, Tina" <tina.zhang@intel.com> - 2017-07-12 04:30 +0200
  Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Gerd Hoffmann <kraxel@redhat.com> - 2017-07-11 08:10 +0200
    RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation "Zhang, Tina" <tina.zhang@intel.com> - 2017-07-12 04:50 +0200
  Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Daniel Vetter <daniel@ffwll.ch> - 2017-07-11 11:20 +0200
    RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation "Zhang, Tina" <tina.zhang@intel.com> - 2017-07-12 05:20 +0200

csiph-web