Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685469

RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation

Show all headers | View raw

> -----Original Message-----
> From: intel-gvt-dev [mailto:intel-gvt-dev-bounces@lists.freedesktop.org] On
> Behalf Of Daniel Vetter
> Sent: Tuesday, July 11, 2017 5:13 PM
> To: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Tian, Kevin <kevin.tian@intel.com>; linux-kernel@vger.kernel.org; intel-
> gfx@lists.freedesktop.org; alex.williamson@redhat.com;
> zhenyuw@linux.intel.com; chris@chris-wilson.co.uk; Kirti Wankhede
> <kwankhede@nvidia.com>; Lv, Zhiyuan <zhiyuan.lv@intel.com>;
> daniel@ffwll.ch; Zhang, Tina <tina.zhang@intel.com>; intel-gvt-
> dev@lists.freedesktop.org; Wang, Zhi A <zhi.a.wang@intel.com>
> Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation
> 
> On Tue, Jul 11, 2017 at 08:14:08AM +0200, Gerd Hoffmann wrote:
> >   Hi,
> >
> > > > +struct vfio_device_query_gfx_plane {
> > > > +	__u32 argsz;
> > > > +	__u32 flags;
> > > > +	struct vfio_device_gfx_plane_info plane_info;
> > > > +	__u32 plane_type;
> > > > +	__s32 fd; /* dma-buf fd */
> > > > +	__u32 plane_id;
> > > > +};
> > > > +
> > >
> > > It would be better to have comment here about what are expected
> > > values for plane_type and plane_id.
> >
> > plane_type is DRM_PLANE_TYPE_*.
> >
> > yes, a comment saying so would be good, same for drm_format which is
> > DRM_FORMAT_*.  While looking at these two: renaming plane_type to
> > drm_plane_type (for consistency) is probably a good idea too.
> >
> > plane_id needs a specification.
> 
> Why do you need plane_type? With universal planes the plane_id along is
> sufficient to identify a plane on a given drm device instance. I'd just remove it.
> -Daniel
The plane_type here, is to ask the mdev vendor driver to return the information according to the value in field plane_type. So, it's a input field.
The values in plane_type field is the same of drm_plane_type. And yes, it's better to use drm_plane_type instead of plane_id. 
Thanks.

Tina
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v10] vfio: ABI for mdev display dma-buf operation Tina Zhang <tina.zhang@intel.com> - 2017-07-06 00:40 +0200
  Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Kirti Wankhede <kwankhede@nvidia.com> - 2017-07-06 16:10 +0200
    Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Gerd Hoffmann <kraxel@redhat.com> - 2017-07-11 08:20 +0200
      Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Daniel Vetter <daniel@ffwll.ch> - 2017-07-11 11:20 +0200
        RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation "Zhang, Tina" <tina.zhang@intel.com> - 2017-07-12 04:40 +0200
          Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Daniel Vetter <daniel@ffwll.ch> - 2017-07-12 09:50 +0200
            Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Kirti Wankhede <kwankhede@nvidia.com> - 2017-07-12 14:50 +0200
              RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation "Zhang, Tina" <tina.zhang@intel.com> - 2017-07-14 03:40 +0200
                Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Kirti Wankhede <kwankhede@nvidia.com> - 2017-07-14 12:20 +0200
                Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Gerd Hoffmann <kraxel@redhat.com> - 2017-07-14 14:10 +0200
                Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Kirti Wankhede <kwankhede@nvidia.com> - 2017-07-14 14:20 +0200
                Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Gerd Hoffmann <kraxel@redhat.com> - 2017-07-17 13:10 +0200
              Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Gerd Hoffmann <kraxel@redhat.com> - 2017-07-14 12:10 +0200
                Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Kirti Wankhede <kwankhede@nvidia.com> - 2017-07-14 12:20 +0200
                Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Gerd Hoffmann <kraxel@redhat.com> - 2017-07-14 14:20 +0200
        Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Zhenyu Wang <zhenyuw@linux.intel.com> - 2017-07-12 05:30 +0200
    RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation "Zhang, Tina" <tina.zhang@intel.com> - 2017-07-12 04:30 +0200
  Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Gerd Hoffmann <kraxel@redhat.com> - 2017-07-11 08:10 +0200
    RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation "Zhang, Tina" <tina.zhang@intel.com> - 2017-07-12 04:50 +0200
  Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation Daniel Vetter <daniel@ffwll.ch> - 2017-07-11 11:20 +0200
    RE: [PATCH v10] vfio: ABI for mdev display dma-buf operation "Zhang, Tina" <tina.zhang@intel.com> - 2017-07-12 05:20 +0200

csiph-web