Re: [PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

From	Moritz Fischer <moritz.fischer@ettus.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev
Date	2017-07-14 05:40 +0200
Message-ID	<u2ZCp-63d-7@gated-at.bofh.it> (permalink)
References	<u2TQm-2st-11@gated-at.bofh.it> <u2TQm-2st-9@gated-at.bofh.it> <u2UW5-34i-5@gated-at.bofh.it> <u2WOd-4e8-1@gated-at.bofh.it> <u2XKi-4Ps-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andrew,

On Thu, Jul 13, 2017 at 6:34 PM, Andrew Lunn <andrew@lunn.ch> wrote:
>> > > + /* not sure if this is the correct way of dealing with this ... */
>> > > + ndev->phydev->supported &= ~(SUPPORTED_Autoneg);
>> > > + ndev->phydev->advertising = ndev->phydev->supported;
>> > > + ndev->phydev->autoneg = AUTONEG_DISABLE;
>> >
>> > What are you trying to achieve?
>>
>> Basically can't do Autoneg, I'll need to take a closer look.
>
> Hi Moritz
>
> What i actually think you mean, is it can only do 1Gbps. So you could
> autoneg, but only advertise 1Gbps. Look at masking out
> PHY_10BT_FEATURES and PHY_100BT_FEATURES.

It does either 1Gbps or 10Gbps (over SFP+), depending which bitstream is loaded
into the  FPGA. In the current setup I could also just have two
different compatible
strings, since neither setup supports the other rate, but that might change.

It seems getting rid of that part (the default values) now works, too.

I'll need to take a closer look tomorrow (and I need to retest with 1Gbps)

>
> Take a look at:
>
> http://elixir.free-electrons.com/linux/latest/source/drivers/net/ethernet/renesas/ravb_main.c#L1045

Will do.

Thanks for feedback,

Moritz

Thread

[PATCH 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev Moritz Fischer <mdf@kernel.org> - 2017-07-13 23:30 +0200
  Re: [PATCH 2/2] net: ethernet: nixge: Add support for National  Instruments XGE netdev Andrew Lunn <andrew@lunn.ch> - 2017-07-14 00:40 +0200
    Re: [PATCH 2/2] net: ethernet: nixge: Add support for National  Instruments XGE netdev Moritz Fischer <moritz.fischer@ettus.com> - 2017-07-14 02:40 +0200
      Re: [PATCH 2/2] net: ethernet: nixge: Add support for National  Instruments XGE netdev Andrew Lunn <andrew@lunn.ch> - 2017-07-14 03:40 +0200
        Re: [PATCH 2/2] net: ethernet: nixge: Add support for National  Instruments XGE netdev Moritz Fischer <moritz.fischer@ettus.com> - 2017-07-14 05:40 +0200
  Re: [PATCH 1/2] dt-bindings: net: Add bindings for National  Instruments XGE netdev Moritz Fischer <moritz.fischer@ettus.com> - 2017-07-14 02:40 +0200
  RE: [PATCH 1/2] dt-bindings: net: Add bindings for National  Instruments XGE netdev YUAN Linyu <Linyu.Yuan@alcatel-sbell.com.cn> - 2017-07-14 02:50 +0200

csiph-web