Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1687013

Re: [PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev
Date 2017-07-14 03:40 +0200
Message-ID <u2XKi-4Ps-19@gated-at.bofh.it> (permalink)
References <u2TQm-2st-11@gated-at.bofh.it> <u2TQm-2st-9@gated-at.bofh.it> <u2UW5-34i-5@gated-at.bofh.it> <u2WOd-4e8-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> > > +	/* not sure if this is the correct way of dealing with this ... */
> > > +	ndev->phydev->supported &= ~(SUPPORTED_Autoneg);
> > > +	ndev->phydev->advertising = ndev->phydev->supported;
> > > +	ndev->phydev->autoneg = AUTONEG_DISABLE;
> > 
> > What are you trying to achieve?
> 
> Basically can't do Autoneg, I'll need to take a closer look.

Hi Moritz

What i actually think you mean, is it can only do 1Gbps. So you could
autoneg, but only advertise 1Gbps. Look at masking out
PHY_10BT_FEATURES and PHY_100BT_FEATURES.

Take a look at:

http://elixir.free-electrons.com/linux/latest/source/drivers/net/ethernet/renesas/ravb_main.c#L1045

It might actually make sense to add a phy_set_min_speed(), a mirror to
phy_set_max_speed().

	Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev Moritz Fischer <mdf@kernel.org> - 2017-07-13 23:30 +0200
  Re: [PATCH 2/2] net: ethernet: nixge: Add support for National  Instruments XGE netdev Andrew Lunn <andrew@lunn.ch> - 2017-07-14 00:40 +0200
    Re: [PATCH 2/2] net: ethernet: nixge: Add support for National  Instruments XGE netdev Moritz Fischer <moritz.fischer@ettus.com> - 2017-07-14 02:40 +0200
      Re: [PATCH 2/2] net: ethernet: nixge: Add support for National  Instruments XGE netdev Andrew Lunn <andrew@lunn.ch> - 2017-07-14 03:40 +0200
        Re: [PATCH 2/2] net: ethernet: nixge: Add support for National  Instruments XGE netdev Moritz Fischer <moritz.fischer@ettus.com> - 2017-07-14 05:40 +0200
  Re: [PATCH 1/2] dt-bindings: net: Add bindings for National  Instruments XGE netdev Moritz Fischer <moritz.fischer@ettus.com> - 2017-07-14 02:40 +0200
  RE: [PATCH 1/2] dt-bindings: net: Add bindings for National  Instruments XGE netdev YUAN Linyu <Linyu.Yuan@alcatel-sbell.com.cn> - 2017-07-14 02:50 +0200

csiph-web