Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1686952

Re: [PATCH v2] clk: qcom: clk-smd-rpm: Fix the reported rate of branches

Show all headers | View raw

On 07/13, Georgi Djakov wrote:
> As there is no way to actually query the hardware for the current clock
> rate, now racalc_rate() just returns the last rate that was previously
> set. But if the rate was not set yet, we return the bogus rate of 1000Hz.
> 
> The branch clocks actually have the same rate as their parent (xo_board),
> so just return this rate.
> 
> Reported-by: Archit Taneja <architt@codeaurora.org>
> Fixes: 00f64b58874e ("clk: qcom: Add support for SMD-RPM Clocks")
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
>  drivers/clk/qcom/clk-smd-rpm.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
> index d990fe44aef3..b45782657ca9 100644
> --- a/drivers/clk/qcom/clk-smd-rpm.c
> +++ b/drivers/clk/qcom/clk-smd-rpm.c
> @@ -364,6 +364,10 @@ static unsigned long clk_smd_rpm_recalc_rate(struct clk_hw *hw,
>  {
>  	struct clk_smd_rpm *r = to_clk_smd_rpm(hw);
>  
> +	/* Return the parent rate for branches */
> +	if (r->branch)
> +		return parent_rate;
> +

What's parent_rate here though? 0? I don't see where we parent
the branch clks to anything.

And we should really just remove the recalc_rate() op for
branches entirely so that we don't have to call down into the
driver to find out something we could have known in the core.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clk: qcom: clk-smd-rpm: Fix the initial rate of branches Georgi Djakov <georgi.djakov@linaro.org> - 2017-07-04 14:40 +0200
  Re: [PATCH] clk: qcom: clk-smd-rpm: Fix the initial rate of branches Archit Taneja <architt@codeaurora.org> - 2017-07-06 12:00 +0200
    Re: [PATCH] clk: qcom: clk-smd-rpm: Fix the initial rate of branches Hans Verkuil <hverkuil@xs4all.nl> - 2017-07-06 12:20 +0200
  Re: [PATCH] clk: qcom: clk-smd-rpm: Fix the initial rate of branches Stephen Boyd <sboyd@codeaurora.org> - 2017-07-13 01:20 +0200
  Re: [PATCH] clk: qcom: clk-smd-rpm: Fix the initial rate of branches Stephen Boyd <sboyd@codeaurora.org> - 2017-07-13 01:20 +0200
    [PATCH v2] clk: qcom: clk-smd-rpm: Fix the reported rate of branches Georgi Djakov <georgi.djakov@linaro.org> - 2017-07-13 15:40 +0200
      Re: [PATCH v2] clk: qcom: clk-smd-rpm: Fix the reported rate of  branches Stephen Boyd <sboyd@codeaurora.org> - 2017-07-14 00:00 +0200
        Re: [PATCH v2] clk: qcom: clk-smd-rpm: Fix the reported rate of  branches Georgi Djakov <georgi.djakov@linaro.org> - 2017-07-14 15:10 +0200
        [PATCH v3] clk: qcom: clk-smd-rpm: Fix the reported rate of branches Georgi Djakov <georgi.djakov@linaro.org> - 2017-07-17 17:40 +0200
          Re: [PATCH v3] clk: qcom: clk-smd-rpm: Fix the reported rate of  branches Stephen Boyd <sboyd@codeaurora.org> - 2017-07-18 03:30 +0200

csiph-web