Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1686841
| From | Justin Ernst <justin.ernst@hpe.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] x86/platform/uv/BAU: Fix congested_response_us not taking effect |
| Date | 2017-07-13 20:50 +0200 |
| Message-ID | <u2Rlv-Ow-3@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Bug fix for the BAU tunable congested_cycles not being set to the user
defined value. Instead of referencing a global variable when deciding
on BAU shutdown, a node will reference its own tunable set
value ( cong_response_us). This results in the user set
tunable value congested_response_us taking effect correctly.
Signed-off-by: Justin Ernst <justin.ernst@hpe.com>
Acked-by: Andrew Banman <abanman@hpe.com>
---
arch/x86/platform/uv/tlb_uv.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
index 2983faa..8ce4657 100644
--- a/arch/x86/platform/uv/tlb_uv.c
+++ b/arch/x86/platform/uv/tlb_uv.c
@@ -40,7 +40,6 @@
static int timeout_us;
static bool nobau = true;
static int nobau_perm;
-static cycles_t congested_cycles;
/* tunables: */
static int max_concurr = MAX_BAU_CONCURRENT;
@@ -849,10 +848,10 @@ static void record_send_stats(cycles_t time1, cycles_t time2,
if ((completion_status == FLUSH_COMPLETE) && (try == 1)) {
bcp->period_requests++;
bcp->period_time += elapsed;
- if ((elapsed > congested_cycles) &&
+ if ((elapsed > usec_2_cycles(bcp->cong_response_us)) &&
(bcp->period_requests > bcp->cong_reps) &&
((bcp->period_time / bcp->period_requests) >
- congested_cycles)) {
+ usec_2_cycles(bcp->cong_response_us))) {
stat->s_congested++;
disable_for_period(bcp, stat);
}
@@ -2247,7 +2246,6 @@ static int __init uv_bau_init(void)
}
nuvhubs = uv_num_possible_blades();
- congested_cycles = usec_2_cycles(congested_respns_us);
uv_base_pnode = 0x7fffffff;
for (uvhub = 0; uvhub < nuvhubs; uvhub++) {
--
1.8.5.6
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] x86/platform/uv/BAU: Fix congested_response_us not taking effect Justin Ernst <justin.ernst@hpe.com> - 2017-07-13 20:50 +0200 [tip:x86/urgent] x86/platform/uv/BAU: Fix congested_response_us not taking effect tip-bot for Justin Ernst <tipbot@zytor.com> - 2017-07-14 11:20 +0200 [tip:x86/urgent] x86/platform/uv/BAU: Fix congested_response_us not taking effect tip-bot for Justin Ernst <tipbot@zytor.com> - 2017-07-16 11:20 +0200
csiph-web