Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1686840

Re: [PATCH 02/17] pci: Add a generic, weakly-linked pcibios_align_resource

Show all headers | View raw

On Wed, 12 Jul 2017 15:50:42 PDT (-0700), helgaas@kernel.org wrote:
> On Tue, Jul 11, 2017 at 06:31:15PM -0700, Palmer Dabbelt wrote:
>> Multiple architectures define this as trivial function, and I'm adding
>> another one as part of the RISC-V port.  This adds a __weak version of
>> pcibios_align_resource and deletes the now obselete ones in a handful of
>> ports.
>>
>> The only functional change should be that a handful of ports used to
>> export pcibios_fixup_bus.  Only some architectures export this, so I
>> just dropped it.
>>
>> Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
>> ---
>>  arch/arc/kernel/pcibios.c        | 13 -------------
>>  arch/arm64/kernel/pci.c          | 17 -----------------
>>  arch/ia64/pci/pci.c              |  7 -------
>>  arch/microblaze/pci/pci-common.c |  7 -------
>>  arch/sparc/kernel/leon_pci.c     |  6 ------
>>  arch/sparc/kernel/pci.c          | 10 ----------
>>  arch/sparc/kernel/pcic.c         |  6 ------
>>  arch/tile/kernel/pci.c           | 10 ----------
>>  arch/tile/kernel/pci_gx.c        |  9 ---------
>>  drivers/pci/setup-res.c          | 12 ++++++++++++
>>  10 files changed, 12 insertions(+), 85 deletions(-)
>
> I think you're making your life harder by including these cleanup
> patches in your RISC-V support.  This patch makes sense (after sorting
> out the issues Luis pointed out), but I think the simplest thing to
> expedite merging is to add the empty stubs for RISC-V like everybody
> else does, then come back after RISC-V gets merged and do the cleanup.
> Then the cleanup clearly goes via the PCI tree and isn't entangled
> with anything else.

Works for me.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 02/17] pci: Add a generic, weakly-linked pcibios_align_resource Palmer Dabbelt <palmer@dabbelt.com> - 2017-07-12 03:40 +0200
  Re: [PATCH 02/17] pci: Add a generic, weakly-linked  pcibios_align_resource "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-07-12 15:50 +0200
  Re: [PATCH 02/17] pci: Add a generic, weakly-linked  pcibios_align_resource Bjorn Helgaas <helgaas@kernel.org> - 2017-07-13 01:00 +0200
    Re: [PATCH 02/17] pci: Add a generic, weakly-linked pcibios_align_resource Palmer Dabbelt <palmer@dabbelt.com> - 2017-07-13 20:40 +0200

csiph-web