Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot()

From	Andreas Färber <afaerber@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot()
Date	2017-07-10 00:00 +0200
Message-ID	<u1spc-4EN-3@gated-at.bofh.it> (permalink)
References	<tZ4Km-6Tf-13@gated-at.bofh.it> <tZFAd-6E3-1@gated-at.bofh.it> <tZIoq-76-7@gated-at.bofh.it> <u0iBA-8tF-11@gated-at.bofh.it>
Organization	SUSE Linux GmbH

Show all headers | View raw

Am 06.07.2017 um 19:17 schrieb Andreas Färber:
> Am 05.07.2017 um 04:36 schrieb Florian Fainelli:
>> On July 4, 2017 4:32:18 PM PDT, "Andreas Färber" <afaerber@suse.de> wrote:
>>> -	writel(virt_to_phys(owl_secondary_startup),
>>> +	writel(virt_to_phys(secondary_startup),
>>> 	       timer_base_addr + OWL_CPU1_ADDR + (cpu - 1) * 4);
>>
>> This is a kernel symbol so please use __pa_symbol() here, also you might want to build with CONFIG_DEBUG_VIRTUAL and see if you get other warnings about using virt_to_phys() in the owl platform code (I did not check if there are other uses)

Florian, I don't spot any build or runtime warning for this
virt_to_phys() with CONFIG_DEBUG_VIRTUAL=y on Guitar/S500:

[    0.062765] CPU: Testing write buffer coherency: ok
[    0.063468] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000
[    0.100856] Setting up static identity map for 0x100000 - 0x100060
[    0.120864] Hierarchical SRCU implementation.
[    0.161092] smp: Bringing up secondary CPUs ...
[    0.291654] CPU1: thread -1, cpu 1, socket 0, mpidr 80000001
[    0.422226] CPU2: thread -1, cpu 2, socket 0, mpidr 80000002
[    0.552798] CPU3: thread -1, cpu 3, socket 0, mpidr 80000003
[    0.553074] smp: Brought up 1 node, 4 CPUs
[    0.553388] SMP: Total of 4 processors activated (1629.38 BogoMIPS).
[    0.553477] CPU: All CPU(s) started in SVC mode.

I've tested that __pa_symbol() works as well, but I'd like to understand
this for commit message and future testing. Am I missing other options?

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

Thread

[PATCH] ARM: owl: smp: Drop owl_secondary_boot() Andreas Färber <afaerber@suse.de> - 2017-07-05 01:40 +0200
  Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Florian Fainelli <f.fainelli@gmail.com> - 2017-07-05 04:40 +0200
    Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Andreas Färber <afaerber@suse.de> - 2017-07-06 19:20 +0200
      Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-07-06 19:40 +0200
        Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Florian Fainelli <f.fainelli@gmail.com> - 2017-07-06 21:50 +0200
          Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-07-07 09:40 +0200
            Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Florian Fainelli <f.fainelli@gmail.com> - 2017-07-07 19:40 +0200
      Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Mark Rutland <mark.rutland@arm.com> - 2017-07-06 19:50 +0200
        Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Florian Fainelli <f.fainelli@gmail.com> - 2017-07-06 23:20 +0200
      Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Andreas Färber <afaerber@suse.de> - 2017-07-10 00:00 +0200
        Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot() Florian Fainelli <f.fainelli@gmail.com> - 2017-07-10 06:30 +0200

csiph-web