Re: [PATCH 2/5] powernv:idle: Change return type of pnv_probe_idle_states to int

Path	csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Gautham R Shenoy <ego@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] powernv:idle: Change return type of pnv_probe_idle_states to int
Date	Fri, 07 Jul 2017 14:40:01 +0200
Message-ID	<u0AI9-40H-9@gated-at.bofh.it> (permalink)
References	<tZVvk-dV-7@gated-at.bofh.it> <tZVvl-dV-27@gated-at.bofh.it> <u0gzN-6G5-39@gated-at.bofh.it>
Reply-To	ego@linux.vnet.ibm.com
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Tm-As-Gconf	00
X-Cbid	17070712-0052-0000-0000-0000023970F0
X-Ibm-Spammodules-Versions	BY=3.00007335; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00884142; UDB=6.00441142; IPR=6.00664329; BA=6.00005455; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016128; XFM=3.00000015; UTC=2017-07-07 12:34:50
X-Ibm-Av-Detection	SAVI=unused REMOTE=unused XFE=unused
X-Cbparentid	17070712-0053-0000-0000-0000513D7A77
X-Proofpoint-Virus-Version	vendor=fsecure engine=2.50.10432:,, definitions=2017-07-07_05:,, signatures=0
X-Proofpoint-Spam-Details	rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1707070206
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	"Gautham R. Shenoy" <ego@linux.vnet.ibm.com>, Michael Ellerman <mpe@ellerman.id.au>, Michael Neuling <mikey@neuling.org>, Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>, Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
X-Original-Date	Fri, 7 Jul 2017 17:56:38 +0530
X-Original-Message-ID	<20170707122638.GB8913@in.ibm.com>
X-Original-References	<1499272696-28751-1-git-send-email-ego@linux.vnet.ibm.com> <1499272696-28751-3-git-send-email-ego@linux.vnet.ibm.com> <20170707010149.7526c784@roar.ozlabs.ibm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1683160

Show key headers only | View raw

Hello Nicholas,

On Fri, Jul 07, 2017 at 01:01:49AM +1000, Nicholas Piggin wrote:
> On Wed,  5 Jul 2017 22:08:13 +0530
> "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> wrote:
> 
> > From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
> > 
> > In the current idle initialization code, if there are failures in
> > pnv_probe_idle_states, then no platform idle state is
> > enabled. However, since the error is not propagated to the top-level
> > function pnv_init_idle_states, we continue initialization in this
> > top-level function even though this will never be used.
> > 
> > Hence change the the return type of pnv_probe_idle_states from void to
> > int and in case of failures, bail out early on in
> > pnv_init_idle_states.
> > 
> > Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> 
> Looks good to me.
> 
> Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
> 
> I wonder if the warnings are strong enough here to let people know
> idle won't be used so power consumption will be high and performance
> significantly reduced on SMT machines?

Good point. Will try to print an error message to this effect.

--
Thanks and Regards
gautham.

Thread

[PATCH 0/5] powernv:idle: Cleanup idle states initialization "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-07-05 18:40 +0200
  [PATCH 3/5] powernv:idle: Define idle init function for power8 "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-07-05 18:40 +0200
    Re: [PATCH 3/5] powernv:idle: Define idle init function for power8 Nicholas Piggin <npiggin@gmail.com> - 2017-07-06 17:10 +0200
      Re: [PATCH 3/5] powernv:idle: Define idle init function for power8 Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2017-07-07 14:50 +0200
  [PATCH 5/5] powernv:idle: Disable LOSE_FULL_CONTEXT states when stop-api fails. "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-07-05 18:40 +0200
    Re: [PATCH 5/5] powernv:idle: Disable LOSE_FULL_CONTEXT states when  stop-api fails. Nicholas Piggin <npiggin@gmail.com> - 2017-07-06 17:30 +0200
      Re: [PATCH 5/5] powernv:idle: Disable LOSE_FULL_CONTEXT states when  stop-api fails. Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2017-07-07 19:40 +0200
        Re: [PATCH 5/5] powernv:idle: Disable LOSE_FULL_CONTEXT states when  stop-api fails. Nicholas Piggin <npiggin@gmail.com> - 2017-07-08 11:10 +0200
          Re: [PATCH 5/5] powernv:idle: Disable LOSE_FULL_CONTEXT states when  stop-api fails. Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2017-07-11 07:10 +0200
  [PATCH 2/5] powernv:idle: Change return type of pnv_probe_idle_states to int "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-07-05 18:40 +0200
    Re: [PATCH 2/5] powernv:idle: Change return type of  pnv_probe_idle_states to int Nicholas Piggin <npiggin@gmail.com> - 2017-07-06 17:10 +0200
      Re: [PATCH 2/5] powernv:idle: Change return type of  pnv_probe_idle_states to int Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2017-07-07 14:40 +0200
  [PATCH 1/5] powernv:idle: Move device-tree parsing to one place. "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-07-05 18:40 +0200
    Re: [PATCH 1/5] powernv:idle: Move device-tree parsing to one  place. Nicholas Piggin <npiggin@gmail.com> - 2017-07-06 17:00 +0200
      Re: [PATCH 1/5] powernv:idle: Move device-tree parsing to one place. Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2017-07-07 13:30 +0200
        Re: [PATCH 1/5] powernv:idle: Move device-tree parsing to one  place. Nicholas Piggin <npiggin@gmail.com> - 2017-07-08 10:50 +0200
  [PATCH 4/5] powernv:idle: Move initialization of sibling pacas to pnv_alloc_idle_core_states "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-07-05 18:40 +0200
    Re: [PATCH 4/5] powernv:idle: Move initialization of sibling pacas  to pnv_alloc_idle_core_states Nicholas Piggin <npiggin@gmail.com> - 2017-07-06 17:20 +0200
      Re: [PATCH 4/5] powernv:idle: Move initialization of sibling pacas  to pnv_alloc_idle_core_states Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2017-07-07 17:10 +0200
        Re: [PATCH 4/5] powernv:idle: Move initialization of sibling pacas  to pnv_alloc_idle_core_states Nicholas Piggin <npiggin@gmail.com> - 2017-07-08 11:10 +0200
          Re: [PATCH 4/5] powernv:idle: Move initialization of sibling pacas to pnv_alloc_idle_core_states Michael Ellerman <mpe@ellerman.id.au> - 2017-07-10 06:40 +0200

csiph-web