Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1628891
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: fbtft: fix character limit, trailing ; warning, etc. |
| Date | 2017-04-23 01:40 +0200 |
| Message-ID | <tzcNc-Li-9@gated-at.bofh.it> (permalink) |
| References | <tz590-4wC-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, 2017-04-22 at 16:26 +0100, Eric Curtin wrote: > checkpatch spits out a warning about the 80 character line limit. Split > the parameters of these functions onto different lines. Put the ; with > the macro caller instead. Lined up parameters as there was another > CHECK warning about that. [] > diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c [] > @@ -24,7 +24,14 @@ void func(struct fbtft_par *par, int len, ...) \ > buf[i] = (type)va_arg(args, unsigned int); \ > } \ > va_end(args); \ > - fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, type, buf, len, "%s: ", __func__); \ > + fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, \ > + par, \ > + par->info->device, \ > + type, \ > + buf, \ > + len, \ > + "%s: ", \ > + __func__); \ > } \ Multiple arguments per line please before 80 columns fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, \ par->info->device, type, buf, len, \ "%s: ", __func__); \
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] staging: fbtft: fix character limit, trailing ; warning, etc. Eric Curtin <ericcurtin17@gmail.com> - 2017-04-22 17:30 +0200 Re: [PATCH] staging: fbtft: fix character limit, trailing ; warning, etc. Joe Perches <joe@perches.com> - 2017-04-23 01:40 +0200
csiph-web