Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Joe Perches Newsgroups: linux.kernel Subject: Re: [PATCH] staging: fbtft: fix character limit, trailing ; warning, etc. Date: Sun, 23 Apr 2017 01:40:02 +0200 Message-ID: References: X-Original-To: Eric Curtin , thomas.petazzoni@free-electrons.com, gregkh@linuxfoundation.org X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3874:4321:4605:5007:9149:10004:10400:10848:11026:11232:11473:11658:11783:11889:11914:12043:12296:12438:12740:12895:13069:13311:13357:13439:13894:13972:14659:14721:21080:30054:30070:30075:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:9,LUA_SUMMARY:none X-He-Tag: light90_1c972cd6a810a X-Filterd-Recvd-Size: 2241 Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 28 Organization: linux.* mail to news gateway X-Original-Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org X-Original-Date: Sat, 22 Apr 2017 16:36:34 -0700 X-Original-Message-ID: <1492904194.30293.40.camel@perches.com> X-Original-References: <1492874769-14446-1-git-send-email-ericcurtin17@gmail.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1628891 On Sat, 2017-04-22 at 16:26 +0100, Eric Curtin wrote: > checkpatch spits out a warning about the 80 character line limit. Split > the parameters of these functions onto different lines. Put the ; with > the macro caller instead. Lined up parameters as there was another > CHECK warning about that. [] > diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c [] > @@ -24,7 +24,14 @@ void func(struct fbtft_par *par, int len, ...) \ > buf[i] = (type)va_arg(args, unsigned int); \ > } \ > va_end(args); \ > - fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, type, buf, len, "%s: ", __func__); \ > + fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, \ > + par, \ > + par->info->device, \ > + type, \ > + buf, \ > + len, \ > + "%s: ", \ > + __func__); \ > } \ Multiple arguments per line please before 80 columns fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,                  \   par->info->device, type, buf, len,          \   "%s: ", __func__);                          \