Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1630060
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq sched_entities |
| Date | 2017-04-24 23:50 +0200 |
| Message-ID | <tzU1P-3Vb-13@gated-at.bofh.it> (permalink) |
| References | <tzSCK-37e-13@gated-at.bofh.it> <tzTS9-3S5-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Apr 24, 2017 at 02:35:28PM -0700, Tejun Heo wrote:
> - if (se->avg.last_update_time && !(flags & SKIP_AGE_LOAD)) {
> - __update_load_avg(now, cpu, &se->avg,
> - se->on_rq * scale_load_down(se->load.weight),
> - cfs_rq->curr == se, NULL);
> + if (entity_is_task(se)) {
> + if (se->avg.last_update_time && !(flags & SKIP_AGE_LOAD))
> + __update_load_avg(now, cpu, &se->avg,
> + se->on_rq * scale_load_down(se->load.weight),
> + cfs_rq->curr == se, NULL);
I've not looked at these patches yet, but you've been patching old code.
__update_load_avg() no longer exists (the conversion shouldn't be too
hard, its mostly been a restructure/rename thing).
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCHSET] sched/fair: fix load balancer behavior when cgroup is in use Tejun Heo <tj@kernel.org> - 2017-04-24 22:20 +0200
[PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq sched_entities Tejun Heo <tj@kernel.org> - 2017-04-24 23:40 +0200
Re: [PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq sched_entities Peter Zijlstra <peterz@infradead.org> - 2017-04-24 23:50 +0200
Re: [PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq sched_entities Tejun Heo <tj@kernel.org> - 2017-04-25 01:00 +0200
Re: [PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq sched_entities Tejun Heo <tj@kernel.org> - 2017-04-25 23:20 +0200
csiph-web