Re: [PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq sched_entities

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq sched_entities
Date	2017-04-25 23:20 +0200
Message-ID	<tAg2m-1uc-9@gated-at.bofh.it> (permalink)
References	<tzSCK-37e-13@gated-at.bofh.it> <tzTS9-3S5-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 24, 2017 at 02:35:28PM -0700, Tejun Heo wrote:
> Now that a cfs_rq sched_entity's load_avg always gets propagated from
> the associated cfs_rq, there's no point in calling __update_load_avg()
> on it.  The two mechanisms compete with each other and we'd be always
> using a value close to the propagated one anyway.
> 
> Skip __update_load_avg() for cfs_rq sched_entities.  Also, relocate
> propagate_entity_load_avg() to signify that propagation is the
> counterpart to __update_load_avg() for cfs_rq sched_entities.  This
> puts the propagation before update_cfs_rq_load_avg() which shouldn't
> disturb anything.

Please ignore this patch.  As we don't propagate on decays, we still
need __update_load_avg() on runanble_load_avg so that it can decay on
its own.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq  sched_entities Tejun Heo <tj@kernel.org> - 2017-04-24 23:40 +0200
  Re: [PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq  sched_entities Peter Zijlstra <peterz@infradead.org> - 2017-04-24 23:50 +0200
    Re: [PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq  sched_entities Tejun Heo <tj@kernel.org> - 2017-04-25 01:00 +0200
  Re: [PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq  sched_entities Tejun Heo <tj@kernel.org> - 2017-04-25 23:20 +0200

csiph-web