RE: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean

Path	csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	David Laight <David.Laight@ACULAB.COM>
Newsgroups	linux.kernel
Subject	RE: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean
Date	Mon, 24 Apr 2017 17:50:03 +0200
Message-ID	<tzOpt-mK-35@gated-at.bofh.it> (permalink)
References	<tyQ0h-3xb-3@gated-at.bofh.it> <tyQ0i-3xb-23@gated-at.bofh.it>
Thread-Topic	[PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean
Thread-Index	AQHSuvab44I2Fu4Mh0SIRtkxy4d02KHUqJOw
Accept-Language	en-GB, en-US
Content-Language	en-US
X-Originating-IP	[10.202.99.200]
Content-Type	text/plain; charset="Windows-1252"
Content-Transfer-Encoding	8BIT
MIME-Version	1.0
X-Outbound-IP	213.249.233.130
X-Env-From	David.Laight@ACULAB.COM
X-Proto	esmtps
X-Helo	AcuExch.aculab.com
X-Tls	TLSv1:AES128-SHA:128
X-Policysmart	3396946, 3397078
X-Virus-Status	Scanned by VirusSMART (c)
X-Virus-Status	Scanned by VirusSMART (s)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "rkrcmar@redhat.com" <rkrcmar@redhat.com>, "dsafonov@virtuozzo.com" <dsafonov@virtuozzo.com>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "emilio.lopez@collabora.co.uk" <emilio.lopez@collabora.co.uk>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>, "luto@kernel.org" <luto@kernel.org>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, "mingo@kernel.org" <mingo@kernel.org>
X-Original-Date	Mon, 24 Apr 2017 15:45:26 +0000
X-Original-Message-ID	<063D6719AE5E284EB5DD2968C1650D6DCFFD98E2@AcuExch.aculab.com>
X-Original-References	<cover.1492815938.git.shuahkh@osg.samsung.com> <b39e21f8c47318d82be999aae310bdf6bcfc9bb9.1492815938.git.shuahkh@osg.samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1629693

Show key headers only | View raw

From: Shuah Khan
> Sent: 22 April 2017 00:15
> Define CLEAN macro to allow Makefiles to override common clean target
> in lib.mk. This will help fix the following failures:
> 
> warning: overriding recipe for target 'clean'
> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
> 
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>  tools/testing/selftests/lib.mk | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 775c589..959273c 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -51,8 +51,12 @@ endef
>  emit_tests:
>  	$(EMIT_TESTS)
> 
> -clean:
> +define CLEAN
>  	$(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN)
> +endef
> +
> +clean:
> +	$(CLEAN)

If might be easier to do something like:

ifneq($(NO_CLEAN),y)
clean:
	$(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN)
endif

	David

Thread

[PATCH 0/8] Fix clean target warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
  [PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
    Re: [PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings Michael Ellerman <mpe@ellerman.id.au> - 2017-04-22 07:50 +0200
      Re: [PATCH 6/8] selftests: splice: override clean in lib.mk to fix  warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-25 17:10 +0200
  [PATCH 4/8] selftests: gpio: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
    Re: [PATCH 4/8] selftests: gpio: override clean in lib.mk to fix warnings Michael Ellerman <mpe@ellerman.id.au> - 2017-04-22 07:50 +0200
      Re: [PATCH 4/8] selftests: gpio: override clean in lib.mk to fix  warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-25 17:10 +0200
  [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
    Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Michael Ellerman <mpe@ellerman.id.au> - 2017-04-22 07:40 +0200
      Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow  Makefiles to override clean Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-25 15:40 +0200
        Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Michael Ellerman <mpe@ellerman.id.au> - 2017-04-26 13:00 +0200
    RE: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow  Makefiles to override clean David Laight <David.Laight@ACULAB.COM> - 2017-04-24 17:50 +0200
      Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow  Makefiles to override clean Shuah Khan <shuah@kernel.org> - 2017-04-24 21:50 +0200
  [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
    Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings Michael Ellerman <mpe@ellerman.id.au> - 2017-04-22 07:50 +0200
      RE: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix  warnings David Laight <David.Laight@ACULAB.COM> - 2017-04-24 18:00 +0200
        Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix  warnings Shuah Khan <shuah@kernel.org> - 2017-04-24 21:50 +0200
      Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix  warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-25 17:10 +0200
  [PATCH 5/8] selftests: powerpc: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
  Re: [PATCH 0/8] Fix clean target warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-28 00:10 +0200

csiph-web